Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add metrics to button (part of #508) #582

Closed
wants to merge 5 commits into from

Conversation

debnil
Copy link
Contributor

@debnil debnil commented Nov 12, 2020

This PR adds metrics functionality to Button.js. A subsequent PR will add the eventName to all invocations of Button.

@debnil
Copy link
Contributor Author

debnil commented Nov 12, 2020

@nikhilsaraf Two questions for you:

  1. What are the "values" that we'd send, as part of the metric event? Of course, the data that already exists on the metricsTracker will be sent. But what else would we add on click.
  2. I suspect that this sendMetricEvent() function will be used in many of the changes we are making. Where would be the best place to put it?

Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can mark as non-draft so we can merge in the next round.

gui/web/src/components/atoms/Button/Button.js Show resolved Hide resolved
gui/web/src/components/atoms/Button/Button.js Outdated Show resolved Hide resolved
gui/web/src/components/atoms/Button/Button.js Outdated Show resolved Hide resolved
gui/web/src/components/atoms/Button/Button.js Outdated Show resolved Hide resolved
gui/web/src/components/atoms/Button/Button.js Outdated Show resolved Hide resolved
@debnil debnil marked this pull request as ready for review December 2, 2020 01:31
Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like should be ready in the next round.

@nikhilsaraf
Copy link
Contributor

closing because work included in #642

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants