Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Send update metric at certain intervals (closes #516) #536

Merged
merged 8 commits into from
Oct 17, 2020

Conversation

debnil
Copy link
Contributor

@debnil debnil commented Oct 15, 2020

This PR modifies our logic to sent the update metric, to send it at certain update intervals. Within 5 minutes of bot start, the interval is every 5 seconds; within 1 hour, every 10 minutes; and after that, every hour. Closes #516.

@debnil debnil requested a review from nikhilsaraf as a code owner October 15, 2020 22:54
@debnil debnil changed the title Send update metric at certain intervals. Send update metric at certain intervals (closes #516) Oct 15, 2020
Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments inline

trader/trader.go Outdated Show resolved Hide resolved
trader/trader.go Outdated Show resolved Hide resolved
trader/trader.go Outdated Show resolved Hide resolved
trader/trader.go Outdated Show resolved Hide resolved
trader/trader_test.go Outdated Show resolved Hide resolved
trader/trader_test.go Outdated Show resolved Hide resolved
trader/trader_test.go Outdated Show resolved Hide resolved
trader/trader_test.go Outdated Show resolved Hide resolved
trader/trader_test.go Outdated Show resolved Hide resolved
@debnil debnil requested a review from nikhilsaraf October 16, 2020 21:03
Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to merge after this round of reviews I think

trader/trader.go Outdated Show resolved Hide resolved
trader/trader_test.go Outdated Show resolved Hide resolved
trader/trader.go Outdated Show resolved Hide resolved
@debnil debnil requested a review from nikhilsaraf October 16, 2020 22:11
Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about antipattern, rest looks good

trader/trader.go Outdated Show resolved Hide resolved
support/metrics/metricsTracker.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thanks! 🎉

@nikhilsaraf nikhilsaraf merged commit c341d64 into stellar-deprecated:master Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8](13) follow-on tasks for Kelp CLI data tracking
2 participants