This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add isTestnet to metric common props (part of #516) #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nikhilsaraf
reviewed
Oct 13, 2020
cmd/trade.go
Outdated
| @@ -527,6 +527,7 @@ func runTradeCmd(options inputs) { | |||
| botConfig.TickIntervalSeconds, | |||
| botConfig.TradingExchange, | |||
| botConfig.TradingPair(), | |||
| strings.Contains(botConfig.HorizonURL, "test"), | |||
There was a problem hiding this comment.
this should be false if trading on centralized exchanges
nikhilsaraf
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
looks good 🚢
thanks for keeping these reviews small, they're much simpler to review.
when you commit these, if there's a way to make the commits show up in the GH issue (probably by referencing the issue number with a hash in the commit message) that would be great for future reference :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
isTestnetboolean field to thecommonPropsstructused in tracking metrics. Part of #516.Below screenshot verifies that if the
userIDis set to "12345" and tested locally, an event with theisTestnetproperty is sent.