Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[5] perf-based CLI metrics #551

Open
nikhilsaraf opened this issue Oct 22, 2020 · 0 comments
Open

[5] perf-based CLI metrics #551

nikhilsaraf opened this issue Oct 22, 2020 · 0 comments
Assignees
@nikhilsaraf
Labels
feature request New feature or request
Milestone
v1.12.0

Comments

@nikhilsaraf
Copy link
Contributor

See "Performance Based Metrics"
https://docs.google.com/document/d/1R5hU7dSloQHZ0XNZkUrS0LPOr2gLVpteXq5NvR-Fy2k/edit#
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Oct 22, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.1 milestone Oct 22, 2020
@debnil debnil mentioned this issue Oct 23, 2020
Merged
@nikhilsaraf nikhilsaraf changed the title [3] perf-based metrics [3] perf-based CLI metrics Oct 26, 2020
@debnil debnil changed the title [3] perf-based CLI metrics [5] perf-based CLI metrics Oct 26, 2020
nikhilsaraf pushed a commit that referenced this issue Oct 28, 2020
@debnil
Add missing CLI metrics from inputs (part of #551) (#555)
586b658 
* Initial commit - missing metrics, existing variables

* Address review - nikhilsaraf
nikhilsaraf pushed a commit that referenced this issue Nov 24, 2020
@debnil
Add metrics for operation counts (part of #551) (#573)
b5d81e6 
* Initial commit

* Fix typo

* Address review - add result struct to trader update.

* Add create metric

* Uncomment metric enablement.

* Address review - refactor create mso, add tests

* Final review - style fixes for countOfferChangeTypes

* NumUpdatesOpsDelete/NumUpdatesOpsUpdate -> NumUpdateOpsDelete/NumUpdateOpsUpdate

* maintain consistent ordering between caller and impl of countOfferChangeTypes
@nikhilsaraf nikhilsaraf modified the milestones: v1.10.1, v1.11.0 Jan 30, 2021
@shanzzam shanzzam assigned nikhilsaraf and unassigned debnil Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
feature request New feature or request
Projects
None yet
Milestone
v1.12.0
Development

No branches or pull requests
2 participants
@nikhilsaraf @debnil