do not crash bot when we encounter a startup event error from Amplitu…

…de (closes #651) (#653)

* 1 - metrics tracker does not error when it fails to send startup event

* 2 - prefix delete event metric log

cmd/trade.go

@@ -626,7 +626,7 @@ func runTradeCmd(options inputs) {
 
 	e = metricsTracker.SendStartupEvent(time.Now())
 	if e != nil {
-		logger.Fatal(l, fmt.Errorf("could not send startup event metric: %s", e))
+		l.Infof("metric - could not send startup event metric: %s", e)
 	}
 
 	// --- start initialization of objects ----
@@ -988,7 +988,7 @@ func deleteAllOffersAndExit(
 	e := metricsTracker.SendDeleteEvent(true)
 	if e != nil {
 		// We don't want to crash upon failure, so offers will be deleted regardless of metric send.
-		l.Infof("could not send delete event metric: %s", e)
+		l.Infof("metric - could not send delete event metric: %s", e)
 	}
 
 	l.Info("")

plugins/metricsTracker.go

@@ -34,6 +34,7 @@ type MetricsTracker struct {
 	isDisabled          bool
 	updateEventSentTime *time.Time
 	cliVersion          string
+	failedStartupSend   bool
 }
 
 // TODO DS Investigate other fields to add to this top-level event.
@@ -261,6 +262,7 @@ func MakeMetricsTracker(
 		isDisabled:          isDisabled,
 		updateEventSentTime: nil,
 		cliVersion:          commonProps.CliVersion,
+		failedStartupSend:   false,
 	}, nil
 }
 
@@ -271,7 +273,12 @@ func (mt *MetricsTracker) GetUpdateEventSentTime() *time.Time {
 
 // SendStartupEvent sends the startup Amplitude event.
 func (mt *MetricsTracker) SendStartupEvent(now time.Time) error {
-	return mt.SendEvent(startupEventName, mt.eventProps, now)
+	e := mt.SendEvent(startupEventName, mt.eventProps, now)
+	if e != nil {
+		mt.failedStartupSend = true
+		return fmt.Errorf("metric - failed to send startup event: %s", e)
+	}
+	return nil
 }
 
 // SendUpdateEvent sends the update Amplitude event.
@@ -319,6 +326,10 @@ func (mt *MetricsTracker) SendEvent(eventType string, eventPropsInterface interf
 		return nil
 	}
 
+	if mt.failedStartupSend {
+		return fmt.Errorf("metric - not sending event metric of type '%s' because we failed to send startup event", eventType)
+	}
+
 	trackerProps := mt.eventProps
 	trackerProps[secondsSinceStartKey] = now.Sub(mt.botStartTime).Seconds()