When in testnet, do not allow secret keys that are valid accounts on …

…the main network (closes #677) (#679)

* 1 - check on backend

* 2 - correct and clean up check on backend

gui/backend/upsert_bot_config.go

@@ -146,6 +146,36 @@ func (s *APIServer) validateConfigs(req upsertBotConfigRequest) *upsertBotConfig
 				errResp.TraderConfig.IssuerB = "cannot trade asset issued by trading account"
 				hasError = true
 			}
+			// use isTradingSdex() function because we have not called Iint() on the trader config yet
+			isPubnetAccount := req.TraderConfig.IsTradingSdex() && strings.TrimSuffix(req.TraderConfig.HorizonURL, "/") == strings.TrimSuffix(s.apiTestNet.HorizonURL, "/")
+			log.Printf("checking if secret key exists on pubnet: isTradingSdex=%v, isPubnetAccount=%v", req.TraderConfig.IsTradingSdex(), isPubnetAccount)
+			if isPubnetAccount {
+				// ensure that trader secret key does not exist on the main net
+				_, e := s.apiPubNet.AccountDetail(horizonclient.AccountRequest{AccountID: *tradingAccount})
+				if e != nil {
+					log.Printf("case: received error from call to check secret key on pubnet")
+					switch t := e.(type) {
+					case *horizonclient.Error:
+						if t.Problem.Status == 404 || strings.ToLower(t.Problem.Title) == "resource missing" {
+							log.Printf("case: account not found on pubnet error so it is valid case")
+							// this is the desired case
+							// do nothing
+						} else {
+							log.Printf("case: error from horizon while validating secret key being used on test network: status = %d, message = %s - %s", t.Problem.Status, t.Problem.Title, t.Problem.Detail)
+							errResp.TraderConfig.TradingSecretSeed = fmt.Sprintf("unknown error from Horizon (%d): %s", t.Problem.Status, t.Problem.Title)
+							hasError = true
+						}
+					default:
+						log.Printf("case: some other non-horizon error")
+						errResp.TraderConfig.TradingSecretSeed = fmt.Sprintf("unknown error checking key on pubnet: %s", e.Error())
+						hasError = true
+					}
+				} else {
+					log.Printf("case: account exists on pubnet, so this is an error!")
+					errResp.TraderConfig.TradingSecretSeed = "account for key exists on pubnet, cannot use on testnet"
+					hasError = true
+				}
+			}
 		}
 	}
 

trader/config.go

@@ -171,7 +171,7 @@ func (b *BotConfig) TradingPair() string {
 
 // IsTradingSdex returns whether the config is set to trade on SDEX
 func (b *BotConfig) IsTradingSdex() bool {
-	return b.isTradingSdex
+	return b.TradingExchange == "" || b.TradingExchange == "sdex"
 }
 
 // TradingExchangeName returns the defaulted trading exchange name
@@ -184,7 +184,7 @@ func (b *BotConfig) TradingExchangeName() string {
 
 // Init initializes this config
 func (b *BotConfig) Init() error {
-	b.isTradingSdex = b.TradingExchange == "" || b.TradingExchange == "sdex"
+	b.isTradingSdex = b.IsTradingSdex()
 
 	if b.AssetCodeA == b.AssetCodeB && b.IssuerA == b.IssuerB {
 		return fmt.Errorf("error: both assets cannot be the same '%s:%s'", b.AssetCodeA, b.IssuerA)