Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add club target shape. #224

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

kevin1kevin1k
Copy link
Contributor

Fixes #164

Describe your changes

Add the Club target shape

Checklist

  • Test cases have been modified/added to cover any code changes.
  • Docstrings have been modified/created for any code changes.
  • All linting and formatting checks pass (see the contributing guidelines for more information).
  • If you added a new dataset or shape, please comment on which datasets worked best for your shape or which shapes worked best for your dataset and provide the GIFs for those here.

Datasets that work best with Club shape:

  • Python
    Python_to_club
  • Dog
    dog_to_club

@github-actions github-actions bot added testing Relating to the testing suite shapes Work relating to shapes module labels Sep 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (51b8d26) to head (0e641cb).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   98.42%   98.45%   +0.02%     
==========================================
  Files          43       43              
  Lines        1775     1807      +32     
  Branches      358      357       -1     
==========================================
+ Hits         1747     1779      +32     
  Misses         25       25              
  Partials        3        3              
Files with missing lines Coverage Δ
src/data_morph/shapes/factory.py 100.00% <ø> (ø)
src/data_morph/shapes/points.py 100.00% <100.00%> (ø)
tests/shapes/test_points.py 100.00% <100.00%> (ø)

@stefmolin stefmolin added this to the 0.3.0 milestone Sep 25, 2024
Copy link
Owner

@stefmolin stefmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kevin1kevin1k! I left a few small comments for you to address, but this looks fantastic 😍

src/data_morph/shapes/points.py Outdated Show resolved Hide resolved
src/data_morph/shapes/points.py Outdated Show resolved Hide resolved
src/data_morph/shapes/points.py Outdated Show resolved Hide resolved
@kevin1kevin1k
Copy link
Contributor Author

Thanks for the suggestions! I have applied them.

Copy link
Owner

@stefmolin stefmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM.

@stefmolin stefmolin merged commit 1f3333c into stefmolin:main Oct 1, 2024
19 checks passed
@kevin1kevin1k kevin1kevin1k deleted the add-clubs-shape branch October 2, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shapes Work relating to shapes module testing Relating to the testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add club target shape
2 participants