Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gorilla to starter_shapes #221

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Sirius207
Copy link
Contributor

@Sirius207 Sirius207 commented Sep 23, 2024

Fixes #180

Describe your changes

I added a Gorilla dataset to starter_shapes, referencing this sample and image source

Currently, the transformation from Gorilla to rectangle has the best effect.

Works Well

  • dots
  • down_parab
  • h_lines
  • high_lines
  • left_parab
  • rectangle
  • right_parab
  • slant_down
  • slant_up
  • x

Just OK

  • circle
  • diamond
  • heart
  • scatter
  • up_parab
  • v_lines
  • wide_lines

Could be Better

  • bullseye
  • rings
  • star

Checklist

  • [NA] Test cases have been modified/added to cover any code changes.
  • [NA] Docstrings have been modified/created for any code changes.
  • All linting and formatting checks pass (see the contributing guidelines for more information).
  • If you added a new dataset or shape, please comment on which datasets worked best for your shape or which shapes worked best for your dataset and provide the GIFs for those here.

gorilla_60%_to_rectangle

@github-actions github-actions bot added the data Work relating to data module label Sep 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.

@stefmolin stefmolin added this to the 0.3.0 milestone Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (51b8d26) to head (c5fbbfc).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files          43       43              
  Lines        1775     1766       -9     
  Branches      358      357       -1     
==========================================
- Hits         1747     1738       -9     
  Misses         25       25              
  Partials        3        3              
Files with missing lines Coverage Δ
src/data_morph/data/loader.py 100.00% <ø> (ø)

Copy link
Owner

@stefmolin stefmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Sirius207! I left one small comment before we can merge this.

src/data_morph/data/loader.py Outdated Show resolved Hide resolved
@stefmolin stefmolin merged commit ac4d124 into stefmolin:main Sep 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Work relating to data module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gorilla starter dataset
2 participants