Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type should be BoundingBox #209

Merged

Conversation

robvdl
Copy link
Contributor

@robvdl robvdl commented Aug 24, 2024

The return type of these three methods is set to None, but it returns a BoundingBox:

  • _derive_data_bounds
  • _derive_morphing_bounds
  • _derive_plotting_bounds

Set the correct return type to BoundingBox instead of None.

Fixes #208

  • Test cases have been modified/added to cover any code changes.
  • Docstrings have been modified/created for any code changes.
  • All linting and formatting checks pass (see the contributing guidelines for more information).

I'm not sure if test cases are needed because this change is so small.

The return type of these three methods is set to None, but it returns a BoundingBox.
@github-actions github-actions bot added the data Work relating to data module label Aug 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (51b8d26) to head (f52c5d3).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files          43       43              
  Lines        1775     1771       -4     
  Branches      358      357       -1     
==========================================
- Hits         1747     1743       -4     
  Misses         25       25              
  Partials        3        3              
Files Coverage Δ
src/data_morph/data/dataset.py 73.07% <100.00%> (ø)

Copy link
Owner

@stefmolin stefmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @robvdl!

@stefmolin stefmolin merged commit 3f2b32a into stefmolin:main Aug 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Work relating to data module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] incorrect return type None should be BoundingBox
2 participants