Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pytweening with local easing functions #158

Merged
merged 9 commits into from
Jun 8, 2024

Conversation

flpm
Copy link
Contributor

@flpm flpm commented May 22, 2024

Fixes #157

What was done:

  • Created new easing functions in plotting/animation
  • Replaced pytweening easing functions in morpher.py with the new functions
  • Removed pytweening as a dependency from pyproject.toml
  • Replaced 'python' with sys.executable in CLI test

@github-actions github-actions bot added testing Relating to the testing suite plotting Work relating to plotting module morpher Work relating to morpher module packaging Relating to packaging labels May 22, 2024
Copy link
Owner

@stefmolin stefmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @flpm!

Let's also include individual tests for each of the new functions. I know they are tested indirectly as part of the DataMorpher, but it would be helpful to have pure tests of their functionality for future changes.

src/data_morph/plotting/animation.py Outdated Show resolved Hide resolved
src/data_morph/plotting/animation.py Outdated Show resolved Hide resolved
src/data_morph/plotting/animation.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (2b0666e) to head (c79215d).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   98.38%   98.42%   +0.03%     
==========================================
  Files          43       43              
  Lines        1737     1775      +38     
  Branches      345      358      +13     
==========================================
+ Hits         1709     1747      +38     
  Misses         25       25              
  Partials        3        3              
Files Coverage Δ
src/data_morph/morpher.py 100.00% <100.00%> (ø)
src/data_morph/plotting/animation.py 97.61% <100.00%> (+4.28%) ⬆️
tests/plotting/test_animation.py 100.00% <100.00%> (ø)
tests/test_main.py 100.00% <100.00%> (ø)

@flpm flpm requested a review from stefmolin May 24, 2024 18:20
@stefmolin stefmolin added this to the 0.3.0 milestone Jun 1, 2024
src/data_morph/plotting/animation.py Outdated Show resolved Hide resolved
src/data_morph/plotting/animation.py Outdated Show resolved Hide resolved
@flpm flpm requested a review from stefmolin June 1, 2024 18:04
@flpm flpm force-pushed the issue-157-factor-out-pytweening branch from 449636f to c79215d Compare June 8, 2024 18:35
@stefmolin stefmolin merged commit a068570 into stefmolin:main Jun 8, 2024
18 checks passed
@flpm flpm deleted the issue-157-factor-out-pytweening branch June 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
morpher Work relating to morpher module packaging Relating to packaging plotting Work relating to plotting module testing Relating to the testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factor out pytweening dependency
2 participants