Skip to content

Commit

Permalink
Let Action fail if git binary can't be located (#261)
Browse files Browse the repository at this point in the history
* Check if git binary exists

* Add Tests
  • Loading branch information
stefanzweifel authored Nov 5, 2022
1 parent 7106b21 commit 0b007fb
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 0 deletions.
3 changes: 3 additions & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ inputs:
create_branch:
description: Create new branch with the name of `branch`-input in local and remote repository, if it doesn't exist yet.
default: false
internal_git_binary:
description: Internal use only! Path to git binary used to check if git is available. (Don't change this!)
default: git

outputs:
changes_detected:
Expand Down
10 changes: 10 additions & 0 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ if "$INPUT_DISABLE_GLOBBING"; then
fi

_main() {
_check_if_git_is_available

_switch_to_repository

if _git_is_dirty || "$INPUT_SKIP_DIRTY_CHECK"; then
Expand Down Expand Up @@ -42,6 +44,14 @@ _main() {
fi
}

_check_if_git_is_available() {
if hash -- "$INPUT_INTERNAL_GIT_BINARY" 2> /dev/null; then
echo "::debug::git binary found.";
else
echo "::error ::git-auto-commit could not find git binary. Please make sure git is available."
exit 1;
fi
}

_switch_to_repository() {
echo "INPUT_REPOSITORY value: $INPUT_REPOSITORY";
Expand Down
12 changes: 12 additions & 0 deletions tests/git-auto-commit.bats
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ setup() {
export INPUT_SKIP_CHECKOUT=false
export INPUT_DISABLE_GLOBBING=false
export INPUT_CREATE_BRANCH=false
export INPUT_INTERNAL_GIT_BINARY=git

# Set GitHub environment variables used by the GitHub Action
temp_github_output_file=$(mktemp -t github_output_test.XXXXX)
Expand Down Expand Up @@ -1041,3 +1042,14 @@ cat_github_output() {
assert_line "::set-output name=changes_detected::false"
refute_line -e "::set-output name=commit_hash::[0-9a-f]{40}$"
}

@test "It fails hard if git is not available" {
INPUT_INTERNAL_GIT_BINARY=binary-does-not-exist

touch "${FAKE_LOCAL_REPOSITORY}"/new-file-{1,2,3}.txt

run git_auto_commit

assert_failure;
assert_line "::error ::git-auto-commit could not find git binary. Please make sure git is available."
}

0 comments on commit 0b007fb

Please sign in to comment.