Patches a potentiell NullPointer when creating the BigDecimal from th…

…e BigInteger while writing the metric.
stefansiegl · Dec 6, 2017 · 7c64260 · 7c64260
1 parent 7abc67a
commit 7c64260
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/main/java/com/appdynamics/extensions/rabbitmq/RabbitMQMonitoringTask.java b/src/main/java/com/appdynamics/extensions/rabbitmq/RabbitMQMonitoringTask.java
@@ -696,17 +696,16 @@ private List<JsonNode> getQueues(ArrayNode queues, String nodeName) {
 
 	public void printMetric(String metricName, BigInteger metricValue, String metricType) {
 
-		String value;
-		if (metricValue != null) {
-			value = metricValue.toString();
-		} else {
-			value = "0";
+		BigInteger metricValueNonNull = metricValue;
+		if (metricValue == null) {
+			metricValueNonNull = new BigInteger("0");
 		}
+
 		if (logger.isDebugEnabled()) {
 			logger.debug("Sending ["
-					+ "] metric = " + metricPrefix + metricName + " = " + value);
+					+ "] metric = " + metricPrefix + metricName + " = " + metricValueNonNull.toString());
 		}
-		this.configuration.getMetricWriter().printMetric(metricPrefix + metricName, new BigDecimal(metricValue),metricType);
+		this.configuration.getMetricWriter().printMetric(metricPrefix + metricName, new BigDecimal(metricValueNonNull),metricType);
 
 	}