Added an option to avoid interrupting the request pipeline #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stefanprodan, please take a look at the PR, it would be great to have this in lib so we don't have to keep a separate fork. |
|
This would be excellent... @cristipufu any input please? Seems PRs are on hold for a while now? Is this still maintained? Thank you so much for all the effort! The new .NET7 lib is not really feature rich as this one and we still remain using this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We use AspNetCoreRateLimit with Redis (as a distributed counter store). And in this use case, Redis might not be available. This causes the target service to stop servicing the requests (due to exception in RateLimitMiddleware). But it is critical for us to keep serving requests even if there are some rate limiting issues (Redis not available or some other issue).
It would be ideal if there was an option to disable interrupting the request pipeline due to rate limiting issues.
Please consider this PR.