Client rate limit by body parameter with multiple values. #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use AspNetCoreRateLimit in our projects. Everything was pretty good until now.
We need additional features for that package as below:
We should apply rate limit rules for clients by requesting body parameters.
The rule must belong to a specific endpoint.
That could be stored in Redis and changeable anytime as dynamically.
I have developed a draft and here are my updates:
I have used ValidationAttribute to reach related property and values and created a custom validation attribute called ClientRateLimitAttribute.
The rest of the code is similar to RateLimitProcessor.
Config as below:
Now we have "EnableBodyParameter" and "BodyParameters" configs.
That code works like this now but I know I can improve more. Before doing that I like to ask that would you support this? And what are your suggestions?
NOTE: I wanted to share the changes as PR, just for review.