Incorporate addons into EmberApp. #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
woow! 📈 |
|
💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 |
|
|
||
| EmberApp.prototype.addonTreesFor = function(step) { |
There was a problem hiding this comment.
step is unclear, maybe type?
Incorporate the `Project` models, recent addon support into `EmberApp`. Uses the following hooks/functions that are called on each addon (if the method exists): * `included` -- Called at the end of the `EmberApp` constructor. * `treesFor` -- Called at various points in the building up of the final dist tree. Receives the name of the step that is being processed. The return value is expected to be a Broccoli tree. The following steps are available with this PR: * `app` * `styles` * `vendor` ---- For a sample addon please take a look at: [ember-cli-pretender](https://github.com/rjackson/ember-cli-pretender/blob/master/index.js) `ember-cli-pretender` can be used (with these changes) via the following steps: ```bash npm install -g ember-cli ember new some-awesome-app cd some-awesome-app npm install --save-dev ember-cli-pretender ember server ``` No modifications are needed to the `Brocfile.js` at all.
|
<3 this is a great start. |
stefanpenner
added a commit
that referenced
this pull request
Jun 14, 2014
Incorporate addons into EmberApp.
rwjblue
added a commit
that referenced
this pull request
Jun 14, 2014
|
👍 |
|
Yay! (y) |
|
this is just great! 😆 |
|
Forgive my ignorance, but how do I import Pretender into a test file? When I instantiate a I have tried a variety of |
|
This is a JSHint warning. You either need to add Pretender to he predef section in your tests/.jshintrc, or add a file specific comment to whitelist it. |
|
Thanks so much for the quick response. I'll modify the .jshintrc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate the
Projectmodels, recent addon support intoEmberApp.Uses the following hooks/functions that are called on each addon (if the method exists):
included-- Called at the end of theEmberAppconstructor.treesFor-- Called at various points in the building up of the final dist tree. Receives the name of the step that is being processed. The return value is expected to be a Broccoli tree. The following steps are available with this PR:appstylesvendorFor a sample addon please take a look at: ember-cli-pretender
ember-cli-pretendercan be used (with these changes) via the following steps:npm install -g ember-cli ember new some-awesome-app cd some-awesome-app npm install --save-dev ember-cli-pretender ember serverNo modifications are needed to the
Brocfile.jsat all.