Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOPATH default value is wrong #5

Closed
AuHau opened this issue Feb 20, 2019 · 3 comments
Closed

GOPATH default value is wrong #5

AuHau opened this issue Feb 20, 2019 · 3 comments

Comments

@AuHau
Copy link

AuHau commented Feb 20, 2019

Even though README says that default values are:

GOROOT: $HOME/.go
GOPATH: $HOME/go

Upon g installation, the GOPATH variable in my config.fish is set to $HOME/.go, which then mess up everything, because upon installation of any version the g binary is removed. Not sure if it is only Fish specific or affects also other shells.

When I have corrected manually this error, everything worked as expected.
@AuHau
Copy link
Author

AuHau commented Feb 20, 2019

Hmmmm, checked your g script and it seems correct. It might be a problem on my system, investigating a bit more. Will let you know.

@AuHau
Copy link
Author

AuHau commented Feb 20, 2019

Hmmm, yeah problem was on my end. The GOPATH variable was set as a universal variable in fish and hence persisted even when I have removed the original export command. From now on, I am avoiding universal variables 😆

@AuHau AuHau closed this as completed Feb 20, 2019
@stefanmaric
Copy link
Owner

Hey @AuHau. Good you solved it!

I think I will add some more info on the install script to let the user know whenever the defaults locations are being used or not.

Thanks for sharing your experience.

stefanmaric added a commit that referenced this issue Jul 8, 2019
@stefanmaric
Warn about installing on a non-default path
a4f8bac 
See #5
stefanmaric added a commit that referenced this issue Jul 8, 2019
@stefanmaric
0.5.0
fa1c8d4 
- Add support for listing and installing unstable versions
- Prevent bugs in config files without final newline
- Ensure the modified PATH is exported on bash and zsh
- Prevent multiple selection of the same shell in g-install
- Improve the --quiet modifier
- Normalize messages styles and wording
- Support double-dash to signal end-of-params
- Tweak README file
- Offer to install latest go version after installing g
- Install requested version when `g run` cannot find it. See #3
- Warn about installing on a non-default path. See #5
- Add goenv to the alternatives list on README
- Add instructions for removal on README
- Make the detection of previously installed g stricter
stefanmaric added a commit that referenced this issue Jul 8, 2019
@stefanmaric
Warn about installing on a non-default path
1fd2d79 
See #5
stefanmaric added a commit that referenced this issue Jul 8, 2019
@stefanmaric
0.5.0
79e47c0 
- Add support for listing and installing unstable versions
- Prevent bugs in config files without final newline
- Ensure the modified PATH is exported on bash and zsh
- Prevent multiple selection of the same shell in g-install
- Improve the --quiet modifier
- Normalize messages styles and wording
- Support double-dash to signal end-of-params
- Tweak README file
- Offer to install latest go version after installing g
- Install requested version when `g run` cannot find it. See #3
- Warn about installing on a non-default path. See #5
- Add goenv to the alternatives list on README
- Add instructions for removal on README
- Make the detection of previously installed g stricter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanmaric @AuHau