-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeOut Option #38
Conversation
Thanks will have a quick look soon. :) |
@mattimatti Test suite is failing. Can you have a look? |
hello Stefan I've updated the test case. Introducing the hashbang handling I've changed the URL#QUALITY format to URL@QUALITY format. I assume it doesn't create problems out of the box. as this url naming is supposed to be internal. Feel free to reject and discuss better solution. |
@@ -35,6 +35,7 @@ module.exports = function(grunt) { | |||
waisenkinder : { | |||
options : { | |||
indexPath : 'photobox/', | |||
timeOut : 1000, | |||
screenSizes : [ '960', '350', '1200' ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we align this one? 😊
Hey hey, thanks for putting the effort into. I checkout out the PR and it doesn't seem to work. UI is broken and the generated images seem to have wrong file names. |
Any news on this one? |
Ping again. :) I think I'm gonna close this one soon'ish, if no there is no response anymore. |
I think I can contribute to this. I'll need this anyway. |
If you're up for it I also can give you access. I'm not using this project anymore and would love to have someone bringing it further. :) |
Sad that you are not using it anymore. Its a great peice of work. Some more tweaks and it should be able to compete with the likes of huxley/ phantom css or wraith. Sure, I can own it. |
Hello I've added a timeOut option as you suggested in #35.
Thank you!