Handle CURLOPT_BINARYTRANSFER deprecation for newer PHP versions #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a private property `_use_binarytransfer` to conditionally apply the `CURLOPT_BINARYTRANSFER` option only on PHP versions older than 5.4 (where it is not deprecated). For newer PHP versions (5.4 and above), this option will no longer be set, ensuring compatibility and avoiding deprecated behavior. The changes aim to maintain backward compatibility with older PHP environments, while ensuring a clean and warning-free behavior on newer ones.
|
i'll look over your changes but unfortunately you changed the formatting of the entire file so it's hard to see at a glance. but i'll look into it |
|
Just so it remains for posterity, it looks like this is the announcement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a private property
_use_binarytransferto conditionally apply theCURLOPT_BINARYTRANSFERoption only on PHP versions older than 5.4 (where it is not deprecated).For newer PHP versions (5.4 and above), this option will no longer be set, ensuring compatibility and avoiding deprecated behavior.
The changes aim to maintain backward compatibility with older PHP environments, while ensuring a clean and warning-free behavior on newer ones.