Fix and Unify Line Break Handling Across Platforms #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Read Issue #78
Implementation
New Condition: I added a new condition which executes when the dropdown check fails. This condition will presume that any input which is not a dropdown is instead a series of text lines separated by one line break each. Under that presumption, the condition will split the text to remove its carriage feed and line break characters. Like toValue(), this condition will return a new text string where each line of text is separated by two new line characters.
Modified Tests: The multiple paragraphs test is updated to reflect the fact that individual lines of text will consistently be separated by two line breaks. If requested, this behavior can be documented somewhere in the README to indicate to users how they should parse text containing line breaks.
Alternatives
I briefly considered modifying how checkboxes were found within the Markdown, but figured this solution would be more lightweight and would help make the JSON output more consistent.
Tests
