fix: multi paragraphs parsing #15
Conversation
gr2m
force-pushed
the
multi-paragraphs-parsing
branch
2 times, most recently
from
a19bc3d
to
7e9878b
Compare
gr2m
force-pushed
the
multi-paragraphs-parsing
branch
from
d07e984
to
e48ab30
Compare
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "textarea": "1st paragraph\n\n2nd paragraph" | |||
There was a problem hiding this comment.
Maybe worth adding another case for a single line break since it is not covered yet.
1st paragraph\n2nd paragraph
If you don't mind, I'm happy to make the change on top of your changes and push it onto this branch.
There was a problem hiding this comment.
Here it is 5360a1d.
While updating the id from textarea to textarea-one, I stumbled across the replacing we do and I wonder if this is actually necessary. If I remember correctly, this was done to produce a nice looking output variable, but in the JSON output this is quite confusing. What do you think, should we get rid of this replace?
Line 47 in c4bc96d
There was a problem hiding this comment.
If you don't mind, I'm happy to make the change on top of your changes and push it onto this branch.
no problem 👍🏼
While updating the
idfromtextareatotextarea-one, I stumbled across the replacing we do and I wonder if this is actually necessary. If I remember correctly, this was done to produce a nice looking output variable, but in the JSON output this is quite confusing. What do you think, should we get rid of this replace?
Yeah +1 on getting rid of that. I think it will confuse people, I don't think this behavior is currently documented either. But maybe fix that in a separate PR?
There was a problem hiding this comment.
Great, I will work on a pull request tomorrow evening. This is a breaking change so I'll update the workflow to push a v2 branch JTLYK.
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Before this change, IDs defined in a GitHub issue template that included a hyphen got converted to dashes for the Action output. This was mainly done to ensure nice-looking output variables. However, this is confusing as discussed in #15 (comment).
BREAKING CHANGE: Before this change, IDs defined in a GitHub issue template that included a hyphen got converted to dashes for the Action output. This was mainly done to ensure nice-looking output variables. However, this is confusing as discussed in #15 (comment).
fixes #14