Skip to content

Commit

Permalink
fix: Do not convert ids to dashes in output
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
Before this change, IDs defined in a GitHub issue template that included a hyphen got converted to dashes for the Action output. This was mainly done to ensure nice-looking output variables. However, this is confusing as discussed in #15 (comment).
  • Loading branch information
Stefan Buck committed Sep 13, 2021
1 parent 21b7212 commit ddc0641
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions fixtures/multiple-paragraphs/expected.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"textarea_one": "1st paragraph\n\n2nd paragraph",
"textarea_two": "1st paragraph\n2nd paragraph"
"textarea-one": "1st paragraph\n\n2nd paragraph",
"textarea-two": "1st paragraph\n2nd paragraph"
}
2 changes: 1 addition & 1 deletion fixtures/readme-example/expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
"browsers": "Chrome, Safari",
"never_give_up": true,
"hot_dog_is_a_sandwich": false
}
}
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async function run(env, eventPayload, fs, core) {

function toKey(str) {
if (idMapping[str]) {
return idMapping[str].replace(/-/g, "_");
return idMapping[str];
}

return str
Expand Down

0 comments on commit ddc0641

Please sign in to comment.