Skip to content

Commit

Permalink
[Data] Ensure all tests use shared cluster in test_csv (ray-project…
Browse files Browse the repository at this point in the history
…#48352)

See
ray-project#48228 (comment).

Signed-off-by: Balaji Veeramani <[email protected]>
  • Loading branch information
bveeramani authored Oct 29, 2024
1 parent 40cf450 commit 40ad2da
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions python/ray/data/tests/test_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -763,11 +763,7 @@ def test_csv_read_filter_non_csv_file(ray_start_regular_shared, tmp_path):
assert ds.to_pandas().equals(df)


# NOTE: The last test using the shared ray_start_regular_shared cluster must use the
# shutdown_only fixture so the shared cluster is shut down, otherwise the below
# test_write_datasink_ray_remote_args test, which uses a cluster_utils cluster, will
# fail with a double-init.
def test_csv_read_no_header(shutdown_only, tmp_path):
def test_csv_read_no_header(ray_start_regular_shared, tmp_path):
from pyarrow import csv

file_path = os.path.join(tmp_path, "test.csv")
Expand All @@ -781,7 +777,7 @@ def test_csv_read_no_header(shutdown_only, tmp_path):
assert df.equals(out_df)


def test_csv_read_with_column_type_specified(shutdown_only, tmp_path):
def test_csv_read_with_column_type_specified(ray_start_regular_shared, tmp_path):
from pyarrow import csv

file_path = os.path.join(tmp_path, "test.csv")
Expand Down

0 comments on commit 40ad2da

Please sign in to comment.