Handle expected AssertionError and AssumptionViolatedException.

Fixes junit-team#687.
stefanbirkner · Aug 6, 2013 · 5085af7 · 5085af7
1 parent 1028d1c
commit 5085af7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/org/junit/rules/ExpectedException.java b/src/main/java/org/junit/rules/ExpectedException.java
@@ -6,7 +6,6 @@
 import static org.junit.Assert.fail;
 import static org.junit.internal.matchers.ThrowableCauseMatcher.hasCause;
 import static org.junit.internal.matchers.ThrowableMessageMatcher.hasMessage;
-
 import org.hamcrest.Matcher;
 import org.hamcrest.StringDescription;
 import org.junit.internal.AssumptionViolatedException;
@@ -199,11 +198,16 @@ private void optionallyHandleException(Throwable e, boolean handleException)
             throws Throwable {
         if (handleException) {
             handleException(e);
-        } else {
+        } else if (!isExpectedException(e)) {
             throw e;
         }
     }
 
+    private boolean isExpectedException(Throwable e) {
+        return fMatcherBuilder.expectsThrowable()
+                && fMatcherBuilder.build().matches(e);
+    }
+
     private void handleException(Throwable e) throws Throwable {
         if (fMatcherBuilder.expectsThrowable()) {
             assertThat(e, fMatcherBuilder.build());

diff --git a/src/test/java/org/junit/tests/experimental/rules/ExpectedExceptionTest.java b/src/test/java/org/junit/tests/experimental/rules/ExpectedExceptionTest.java
@@ -286,7 +286,6 @@ public static class ThrowExpectedAssertionError {
 
         @Test
         public void wrongException() {
-            thrown.handleAssertionErrors();
             thrown.expect(AssertionError.class);
             throw new AssertionError("the expected assertion error");
         }
@@ -298,7 +297,6 @@ public static class DontThrowAssertionErrorButExpectOne {
 
         @Test
         public void assertionErrorExpectedButNonIsThrown() {
-            thrown.handleAssertionErrors();
             thrown.expect(AssertionError.class);
         }
     }
@@ -333,7 +331,6 @@ public static class ThrowExpectedAssumptionViolatedException {
 
         @Test
         public void throwExpectAssumptionViolatedException() {
-            thrown.handleAssumptionViolatedExceptions();
             thrown.expect(AssumptionViolatedException.class);
             throw new AssumptionViolatedException("");
         }