Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month duration for X-label #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burntfalafel
Copy link

@burntfalafel burntfalafel commented Jul 21, 2024

Thanks for creating a simple gantt chart repo!

This PR removes your week duration labels in the x-axis to be replaced by MM-YYYY (month-year) labels. format can be adjusted in gantt.py.

maybe you can do a if/else implementation i.e. (if int it's a week label else the MM-YYYY format).

Idk upto you man :)

@stefanSchinkel
Copy link
Owner

Hi @burntfalafel,

sorry for taking so long to get back to you (i was on holidays when the PR came and I forgot to set a reminder 🤦‍♂️ ). Anyhow, thanks for the effort (in particular for also fixing the many typos). I do like the idea of having actual dates on the axis but I reckon it would be handy to be able to use discrete values as well (like, if you're still in planning and have no idea on the actual dates).

This would need like some sanity checking if all labels are in the same format and some switching of label types (and tests for that obviously). Would you be willing to add that or should I take over?

best & thx again,
Stefan

@burntfalafel
Copy link
Author

burntfalafel commented Oct 4, 2024

Ay, no all good. Hope you had a good one.

I can take a quick look later to get this all in place. I really like the simplicity of this repo, so I will try to maintain that theme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants