-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Pandas deprecation warnings. #263
base: main
Are you sure you want to change the base?
Conversation
Thanks @jimwhite , please let me know if you have any questions. Hope the new release suits your situation. |
Well, the problem (high warning count when running tests) is now 53371 (up from around 31K):
My reason for trying to get the warning count down to something more manageable is I'm thinking in terms of future maintenance and enhancements for zipline-reloaded. For example I'm working on a Polygon.io bundle (https://github.com/fovi-llc/zipline-polygon-bundle) and that bcolz is now also reloaded has me thinking about replacing that with (or adding the alternative of) using PyArrow Hive. Shall I update my PR to this new HEAD? |
Hi Stefan,
This is the bulk of changes needed to reduce/eliminate Pandas future/deprecation warnings when using Pandas 2.2. There were about 33000 when running the tests and this gets down to around 1500. This change is a WIP but I wanted to create the PR early and get your feedback on how to proceed. I'm also still dealing with errors in
tests/data/test_daily_bars.py
andtests/test_bar_data.py
(I think the issue has to do with the timestamp format in the test data init).I've only tested with Python 3.11 on MacOS so I expect to see issues from the other versions in the GitHub Actions testing.
I really appreciate the work you've done to keep Zipline alive. I've got a Polygon.io stock data bundle in progress (https://github.com/fovi-llc/zipline-polygon-bundle) which is finally working end-to-end (but needing much to do yet).
Thanks!
Jim