Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection pool #210

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Fix connection pool #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e5ef86
DOC: updating docs
stefan-jansen Jul 17, 2023
8ef28b9
fix link syntax
stefan-jansen Jul 17, 2023
52520fb
disable connection pooling
stefan-jansen Jul 18, 2023
bdb398d
Merge branch 'docs'
stefan-jansen Jul 18, 2023
03bd61e
Merge branch 'main' into fix_connection_pool
stefan-jansen Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/source/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ Documentation <https://conda.io/projects/conda/en/latest/user-guide/install/inde

Once ``conda`` has been set up you can install Zipline from the ``conda-forge`` channel.

See [here](https://github.com/conda-forge/zipline-reloaded-feedstock) for the latest installation details.

See `here <https://github.com/conda-forge/zipline-reloaded-feedstock>`_ for the latest installation details.

.. _managing-conda-environments:

Expand Down Expand Up @@ -178,7 +177,7 @@ You can install Zipline by running

.. code-block:: bash

(env_zipline) $ conda install -c ml4t zipline-reloaded
(env_zipline) $ conda install -c conda-forge zipline-reloaded

To deactivate the ``conda`` environment:

Expand Down
3 changes: 2 additions & 1 deletion src/zipline/utils/sqlite_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import sqlite3

import sqlalchemy as sa
from sqlalchemy.pool import NullPool

from .input_validation import coerce_string

Expand All @@ -42,7 +43,7 @@ def check_and_create_connection(path, require_exists):
def check_and_create_engine(path, require_exists):
if require_exists:
verify_sqlite_path_exists(path)
return sa.create_engine("sqlite:///" + path)
return sa.create_engine("sqlite:///" + path, poolclass=NullPool)


def coerce_string_to_conn(require_exists):
Expand Down