-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Pytest refactoring #15
MAINT: Pytest refactoring #15
Conversation
There are varying (small) numbers of tests failing with pandas 1.1, such as some of the example strategies. |
I can confirm on my machine (Debian 10, python3.8.5) that indeed pandas-1.1.5 is failing the test_examples.py , it wasn't such a bad idea to re-enable the tests_examples after all... (pandas-1.2.4 passes the test) The issue is not clear to me yet but the class dataframe_cache(MutableMapping) can't load the data |
I think the example tests fail because there need to be data for each pandas version (see (example_data)[https://github.com/stefan-jansen/zipline-reloaded/tree/main/tests/resources] files - data and |
Indeed I completely overlooked that (facepalm) .... pandas could be indeed considered mature enough for considering only minor numbering changes. BTW rebuild_example_data hasn't been deleted from the repo when you added the missing extension. |
Both Windows and macOS fail because of Py3.9 dependencies (Windows - HDF5, macOS due to c-blosc). We can skip Windows for 3.9; there's a homebrew formula for c-blosc, perhaps that does the trick, will check tomorrow. I'll merge anyway as this is unrelated. |
Refactored the asset classes to take advantage of pytest fixtures
re-enabled a test example that was originally skipped (it works on linux)