Skip to content

Commit

Permalink
BUG: Fix connection pool (#210)
Browse files Browse the repository at this point in the history
* disable connection pooling so ingestion works on Windows (see #209)
* DOC: updating docs
* fix link syntax
  • Loading branch information
stefan-jansen authored Jul 18, 2023
1 parent 206888c commit 5d1aa4e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions docs/source/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ Documentation <https://conda.io/projects/conda/en/latest/user-guide/install/inde

Once ``conda`` has been set up you can install Zipline from the ``conda-forge`` channel.

See [here](https://github.com/conda-forge/zipline-reloaded-feedstock) for the latest installation details.

See `here <https://github.com/conda-forge/zipline-reloaded-feedstock>`_ for the latest installation details.

.. _managing-conda-environments:

Expand Down Expand Up @@ -178,7 +177,7 @@ You can install Zipline by running

.. code-block:: bash
(env_zipline) $ conda install -c ml4t zipline-reloaded
(env_zipline) $ conda install -c conda-forge zipline-reloaded
To deactivate the ``conda`` environment:

Expand Down
3 changes: 2 additions & 1 deletion src/zipline/utils/sqlite_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import sqlite3

import sqlalchemy as sa
from sqlalchemy.pool import NullPool

from .input_validation import coerce_string

Expand All @@ -42,7 +43,7 @@ def check_and_create_connection(path, require_exists):
def check_and_create_engine(path, require_exists):
if require_exists:
verify_sqlite_path_exists(path)
return sa.create_engine("sqlite:///" + path)
return sa.create_engine("sqlite:///" + path, poolclass=NullPool)


def coerce_string_to_conn(require_exists):
Expand Down

0 comments on commit 5d1aa4e

Please sign in to comment.