Update gems

- All gems are updated to their latest version. - Rubocop's upgrade came with some new offenses, hence their fix.
steeple-org · Sep 1, 2023 · 0fdb928 · 0fdb928
1 parent 0dd792b
commit 0fdb928
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 52 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -41,6 +41,9 @@ RSpec/ContextWording:
 RSpec/ExampleLength:
   Max: 15
 
+RSpec/IndexedLet:
+  Enabled: false
+
 RSpec/MessageSpies:
   Enabled: false
 

diff --git a/Gemfile b/Gemfile
@@ -5,18 +5,18 @@ source "https://rubygems.org"
 gemspec
 
 # A BDD test harness for Ruby
-gem "rspec", "~> 3.11"
+gem "rspec", "~> 3.12"
 
 # Code coverage for Ruby
-gem "simplecov", "~> 0.21.2"
+gem "simplecov", "~> 0.22.0"
 
 # A Ruby static code analyzer and formatter
-gem "rubocop", "~> 1.30"
-gem "rubocop-performance", "~> 1.14"
-gem "rubocop-rspec", "~> 2.11"
+gem "rubocop", "~> 1.56"
+gem "rubocop-performance", "~> 1.19"
+gem "rubocop-rspec", "~> 2.23"
 
 # A Ruby documentation tool
-gem "yard", "~> 0.9.28"
+gem "yard", "~> 0.9.34"
 
 # An optional library, used to parse XLSX documents when needed
-gem "roo", "~> 2.9"
+gem "roo", "~> 2.10"
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -7,77 +7,88 @@ GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
+    base64 (0.1.1)
     diff-lcs (1.5.0)
     docile (1.4.0)
-    nokogiri (1.13.6-x86_64-darwin)
+    json (2.6.3)
+    language_server-protocol (3.17.0.3)
+    nokogiri (1.15.4-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.13.6-x86_64-linux)
+    nokogiri (1.15.4-x86_64-linux)
       racc (~> 1.4)
-    parallel (1.22.1)
-    parser (3.1.2.0)
+    parallel (1.23.0)
+    parser (3.2.2.3)
       ast (~> 2.4.1)
-    racc (1.6.0)
+      racc
+    racc (1.7.1)
     rainbow (3.1.1)
-    regexp_parser (2.5.0)
-    rexml (3.2.5)
-    roo (2.9.0)
+    regexp_parser (2.8.1)
+    rexml (3.2.6)
+    roo (2.10.0)
       nokogiri (~> 1)
       rubyzip (>= 1.3.0, < 3.0.0)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.2)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.6)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.30.0)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.1)
+    rubocop (1.56.2)
+      base64 (~> 0.1.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.18.0, < 2.0)
+      rubocop-ast (>= 1.28.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.18.0)
-      parser (>= 3.1.1.0)
-    rubocop-performance (1.14.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.29.0)
+      parser (>= 3.2.1.0)
+    rubocop-capybara (2.18.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.23.1)
+      rubocop (~> 1.33)
+    rubocop-performance (1.19.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.11.1)
-      rubocop (~> 1.19)
-    ruby-progressbar (1.11.0)
+    rubocop-rspec (2.23.2)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+    ruby-progressbar (1.13.0)
     rubyzip (2.3.2)
-    simplecov (0.21.2)
+    simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    unicode-display_width (2.1.0)
-    webrick (1.7.0)
-    yard (0.9.28)
-      webrick (~> 1.7.0)
+    unicode-display_width (2.4.2)
+    yard (0.9.34)
 
 PLATFORMS
   x86_64-darwin
   x86_64-linux
 
 DEPENDENCIES
-  roo (~> 2.9)
-  rspec (~> 3.11)
-  rubocop (~> 1.30)
-  rubocop-performance (~> 1.14)
-  rubocop-rspec (~> 2.11)
+  roo (~> 2.10)
+  rspec (~> 3.12)
+  rubocop (~> 1.56)
+  rubocop-performance (~> 1.19)
+  rubocop-rspec (~> 2.23)
   sheetah!
-  simplecov (~> 0.21.2)
-  yard (~> 0.9.28)
+  simplecov (~> 0.22.0)
+  yard (~> 0.9.34)
 
 BUNDLED WITH
-   2.3.15
+   2.4.19
diff --git a/lib/sheetah/errors/error.rb b/lib/sheetah/errors/error.rb
@@ -28,7 +28,7 @@ def build_msg_code
           end
 
           msg_code = name.dup
-          msg_code.gsub!(/::/, ".")
+          msg_code.gsub!("::", ".")
           msg_code.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
           msg_code.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
           msg_code.downcase!

diff --git a/lib/sheetah/template_config.rb b/lib/sheetah/template_config.rb
@@ -12,7 +12,7 @@ def initialize(types: Types::Container.new)
 
     def header(key, index)
       header = key.to_s.capitalize
-      header = index ? "#{header} #{index + 1}" : header
+      header = "#{header} #{index + 1}" if index
 
       pattern = /^#{header}$/i
 

diff --git a/spec/sheetah/types/scalars/date_string_cast_spec.rb b/spec/sheetah/types/scalars/date_string_cast_spec.rb
@@ -29,7 +29,7 @@
       end
 
       before do
-        allow(::Date).to receive(:===).with(value).and_return(true)
+        allow(Date).to receive(:===).with(value).and_return(true)
       end
 
       context "when accepting Date" do