Prevent npm preload module to break dev bundles #1003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #947
Part of the problem is that the module to preload the npm packages is added at the top of the bundle. So we run into situations like:
then the amd extension can't see the "define" because the comments regex matches a bunch of the module definition:
The solution I came up with was to push the module with the package.jsons to the bottom of the bundle, that way the first thing the regex matches is the actual AMD modules.
Placing the preloader at the bottom shouldn't matter since it gets executed right away.