Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CleanCSS incorrectly updates url()s when using bundles #689

Closed
phillipskevin opened this issue Apr 28, 2017 · 0 comments
Closed

CleanCSS incorrectly updates url()s when using bundles #689

phillipskevin opened this issue Apr 28, 2017 · 0 comments
Assignees
@m-mujica
Labels
bug in progress

Comments

@phillipskevin
Copy link
Contributor

CleanCSS will update url()s under certain conditions in CSS when minifying. These url()s are already updated prior to bundling, so this can cause URLs to be broken. I believe we should set rebase: false in the cleanCSSOptions.
@matthewp matthewp added the bug label May 1, 2017
@m-mujica m-mujica self-assigned this May 1, 2017
m-mujica pushed a commit that referenced this issue May 1, 2017
Prevent clean-css to rebase urls
d0e3cf0 
Closes #689
@m-mujica m-mujica mentioned this issue May 1, 2017
Merged
m-mujica pushed a commit that referenced this issue May 3, 2017
Prevent clean-css to rebase urls
f32d59b 
Closes #689
m-mujica pushed a commit that referenced this issue May 3, 2017
Prevent clean-css to rebase urls
1c3bc69 
Closes #689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-mujica m-mujica

Labels
bug in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewp @m-mujica @phillipskevin