Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make untangle available from conda-forge #75

Merged
merged 8 commits into from
Jul 1, 2020
Merged

Conversation

HTenkanen
Copy link
Contributor

Closes #72

Untangle has been added to conda-forge feedstock. Adds documentation about how to install with conda.

@coveralls
Copy link

coveralls commented Jun 30, 2020

Coverage Status

Coverage increased (+0.6%) to 35.514% when pulling a3a0b92 on HTenkanen:master into cd441fd on stchris:master.

Copy link
Owner

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I added some small suggestions.

Additionally:

  • would you mind adding yourself to the CONTRIBUTORS file
  • would you mind adding a line about packaging being your responsibility, perhaps with a link to your github username so people can tag you / find you?

Thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
HTenkanen and others added 6 commits July 1, 2020 13:14
Co-authored-by: Christian Stefanescu <[email protected]>
Co-authored-by: Christian Stefanescu <[email protected]>
Co-authored-by: Christian Stefanescu <[email protected]>
Co-authored-by: Christian Stefanescu <[email protected]>
@HTenkanen
Copy link
Contributor Author

@stchris Okay, added comment about conda maintenance to the readme and added myself to the contributors.

@stchris stchris merged commit 43ac668 into stchris:master Jul 1, 2020
@stchris
Copy link
Owner

stchris commented Jul 1, 2020

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make untangle installable from conda-forge?
3 participants