Laravel 9.x Compatibility

[laravel-shift]

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

• Checkout the l9-compatibility branch
• Review all comments for additional changes
• Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

[laravel-shift]

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

[laravel-shift]

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-upsert.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "staudenmeir/laravel-upsert": "dev-l9-compatibility",
    }
}

Finally, run: composer update

[staudenmeir]

The package doesn't work with Laravel 9: #26 (comment)

[jasonmccreary]

@staudenmeir, gotcha. Thanks. I'll make a note on Shift's side.

[deevus]

@staudenmeir Just wanted to make a note here.

It seems that starting with Laravel 9, if you're using MySQL, the in-built upsert method does not really work as it should. It doesn't really say why that is the case other than the following warning (emphasis mine):

All databases except SQL Server require the columns in the second argument of the upsert method to have a "primary" or "unique" index. In addition, the MySQL database driver ignores the second argument of the upsert method and always uses the "primary" and "unique" indexes of the table to detect existing records.

I am wondering that is an opportunity for this package to work with Laravel 9.

Source

[staudenmeir]

Hi @deevus,
This is actually not an issue with the Laravel implementation – that's how MySQL's (only) upsert feature works. There's no workaround for that.

[deevus]

Right. The part that's confusing me then is that our codebase is using upsert with Laravel 8 and MySQL and it works fine. Upgrading to Laravel 9 and now upsert doesn't work.

[staudenmeir]

Maybe it's related to this change? laravel/framework#42053

[deevus]

Don't think so. As far as I can tell that's an opt-in change where you need to set use_upsert_alias to true in the mysql config.

[staudenmeir]

In any case: If there's an issue with the Laravel 9 implementation, it needs to be fixed there. The package can't take care of that.

[deevus]

No worries thanks for your help