add per IP rate limitting #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
approved these changes
May 29, 2024
telemetry/ratelimiter.go
Outdated
| rl.lock.Lock() | ||
| defer rl.lock.Unlock() | ||
|
|
||
| delete(rl.limiters, ip) |
There was a problem hiding this comment.
As described in golang/go#20135 , maps do not shrink when deleting elements, so we might possible run into a slow memleak here. Consider using something like https://github.com/go-auxiliaries/shrinking-map
There was a problem hiding this comment.
Ah, good to know:) I'll switch to that implementation
|
Switched to the shrinking-map - notice I had to bump the golang version in It would be probably best to first merge #18, so that I can lean on the logger added there |
vpavlin
force-pushed
the
feat/add-ratelimiter
branch
from
bc48b30 to
443814e
Compare
vpavlin
force-pushed
the
feat/add-ratelimiter
branch
2 times, most recently
from
5e42c90 to
a8fcc7d
Compare
vpavlin
force-pushed
the
feat/add-ratelimiter
branch
from
a8fcc7d to
296d312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't have any authentication (and don't realyl want to), we should at least have ability to rate limit the requests towards the Telemetry service.
This is a first minimalist attempt to do this - it adds per IP (based on
RemoteAddr) rate limiters - currently set to 10 requests per second per IP.It also cleans up existing rate limiters after not being used for an hour
WDYT @richard-ramos ?