Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep icon color if defined as part of button #479

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

jkbktl
Copy link
Collaborator

@jkbktl jkbktl commented Sep 14, 2023

This code:
carbon

was translated as this:
Screenshot 2023-09-14 at 21 55 14

Color of button variant was automatically applied. But there are cases where we need to apply specific icon color. In case color is defined for icon, defined color is used.

In case it's icon only variant, classic color variant of button is applied.

After change:
Screenshot 2023-09-14 at 21 54 45

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: d8f198b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 14, 2023

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
status-components ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2023 8:10pm
status-web ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2023 8:10pm

@jkbktl jkbktl marked this pull request as ready for review September 14, 2023 20:38
@jkbktl jkbktl merged commit a43b5a6 into status-im:main Sep 15, 2023
3 checks passed
@jkbktl jkbktl deleted the fix/button-icon branch September 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants