Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove url signatures #461

Merged
merged 4 commits into from
Aug 10, 2023
Merged

remove url signatures #461

merged 4 commits into from
Aug 10, 2023

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Jul 27, 2023

closes #459

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: fed8fb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 27, 2023

@felicio is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@felicio felicio self-assigned this Jul 27, 2023
@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 2:00pm

]
],
"rules": {
"@next/next/no-html-link-for-pages": "off"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you turn-off this rule?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

felicio@Felicios-MacBook-Pro web % yarn lint
yarn run v1.22.19
$ eslint src
Pages directory cannot be found at /Users/felicio/Projects/status-im/status-web/apps/web/pages or /Users/felicio/Projects/status-im/status-web/apps/web/src/pages. If using a custom path, please configure with the `no-html-link-for-pages` rule in your eslint config file.
✨  Done in 1.11s.

the /apps/web here doesn't use next, but left other next lint rules since they didn't report any other problems and figured why not

Copy link
Collaborator

@jkbktl jkbktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felicio felicio merged commit 6c24833 into status-im:main Aug 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop signing of status.app links
3 participants