Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emoji hash function #343

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Add emoji hash function #343

merged 3 commits into from
Feb 21, 2023

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Feb 12, 2023

No description provided.

@felicio
Copy link
Collaborator Author

felicio commented Feb 14, 2023

Relates to #327

prichodko
prichodko approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@prichodko prichodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern (as always) is including the dictionary in the main bundle.

I don't think the concern should block this. But alternative solutions would be:

  1. Using a public CDN (example)
  2. Download it on demand (example)

@felicio felicio mentioned this pull request Feb 21, 2023
Open
@felicio felicio merged commit 2596fc1 into status-im:main Feb 21, 2023
felicio added a commit to felicio/status-web that referenced this pull request May 15, 2023
@felicio
Add emoji hash function (status-im#343)
1faeb69 
* add emojis

* add func

* add tests
@felicio felicio self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prichodko prichodko prichodko approved these changes

Assignees

@felicio felicio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felicio @prichodko