Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datemark calculation not taking into account local time #7678

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Fix datemark calculation not taking into account local time #7678

merged 1 commit into from
Mar 6, 2019

Conversation

cammellos
Copy link
Contributor

Fixes: #5281

status: ready

@cammellos cammellos self-assigned this Mar 5, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@cammellos cammellos requested review from yenda and rasom March 5, 2019 12:21
@status-im-auto
Copy link
Member

status-im-auto commented Mar 5, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6393f74 #1 2019-03-05 12:36:12 ~14 min macos 📦 dmg
✔️ 6393f74 #1 2019-03-05 12:37:46 ~16 min ios 📦 ipa
✔️ 6393f74 #1 2019-03-05 12:38:06 ~16 min android-e2e 📦 apk
✔️ 6393f74 #1 2019-03-05 12:41:17 ~19 min android 📦 apk
✔️ 6393f74 #1 2019-03-05 12:41:46 ~20 min windows 📦 exe
✔️ 6393f74 #1 2019-03-05 12:42:48 ~21 min linux 📦 App
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 221f4a8 #3 2019-03-06 15:07:45 ~17 min ios 📦 ipa
✔️ 221f4a8 #3 2019-03-06 15:10:02 ~19 min windows 📦 exe
✔️ 221f4a8 #3 2019-03-06 15:11:33 ~21 min android-e2e 📦 apk
✔️ 221f4a8 #3 2019-03-06 15:11:38 ~21 min android 📦 apk
✔️ 221f4a8 #3 2019-03-06 15:12:56 ~22 min macos 📦 dmg
✔️ 221f4a8 #3 2019-03-06 15:16:00 ~25 min linux 📦 App
✔️ 382eeaa #4 2019-03-06 18:55:58 ~17 min android-e2e 📦 apk

@churik churik self-assigned this Mar 6, 2019
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network (TestRail link is not found)
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages (TestRail link is not found)
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login (TestRail link is not found)
Device sessions

10. test_pass_phrase_validation (TestRail link is not found)
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_open_chat_by_pasting_public_key (TestRail link is not found)
Device sessions

13. test_password_in_logcat_sign_in
Device sessions

14. test_set_profile_picture (TestRail link is not found)
Device sessions

15. test_text_message_1_1_chat
Device sessions

16. test_add_to_contacts
Device sessions

17. test_unread_messages_counter_1_1_chat
Device sessions

18. test_logcat_send_transaction_from_daap
Device sessions

19. test_onboarding_screen_when_requesting_tokens_for_new_account (TestRail link is not found)
Device sessions

20. test_logcat_send_transaction_from_wallet
Device sessions

21. test_send_token_with_7_decimals
Device sessions

22. test_modify_transaction_fee_values
Device sessions

23. test_token_with_more_than_allowed_decimals (TestRail link is not found)
Device sessions

24. test_send_eth_from_wallet_to_address
Device sessions

25. test_send_transaction_details_in_1_1_chat (TestRail link is not found)
Device sessions

26. test_manage_assets
Device sessions

27. test_wallet_set_up (TestRail link is not found)
Device sessions

28. test_logcat_send_transaction_in_1_1_chat
Device sessions

29. test_request_and_receive_eth_in_1_1_chat
Device sessions

30. test_swipe_to_delete_public_chat
Device sessions

31. test_passphrase_whitespaces_ignored_while_recovering_access (TestRail link is not found)
Device sessions

32. test_send_emoji
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens (TestRail link is not found)
Device sessions

46. test_send_message_to_newly_added_contact (TestRail link is not found)
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@churik
Copy link
Member

churik commented Mar 6, 2019

@cammellos
see the same issue (checked on IOS and Mac OS build).

I'm located in GMT+1, but yesterday and today are split by GMT 00 (checked in #status channel)
kjlsdfd

@cammellos cammellos force-pushed the bug/wrong-datemark branch 2 times, most recently from bf85eeb to 221f4a8 Compare March 6, 2019 14:50
@cammellos
Copy link
Contributor Author

@churik should be fixed in the next build, sorry for the inconvenience.

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 45
Failed tests: 0
Passed tests: 45

Passed tests (45)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_request_and_receive_tokens_in_1_1_chat
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_add_to_contacts
Device sessions

10. test_unread_messages_counter_1_1_chat
Device sessions

11. test_logcat_send_transaction_from_daap
Device sessions

12. test_send_message_in_group_chat
Device sessions

13. test_logcat_send_transaction_from_wallet
Device sessions

14. test_send_token_with_7_decimals
Device sessions

15. test_modify_transaction_fee_values
Device sessions

16. test_send_eth_from_wallet_to_address
Device sessions

17. test_manage_assets
Device sessions

18. test_logcat_send_transaction_in_1_1_chat
Device sessions

19. test_request_and_receive_eth_in_1_1_chat
Device sessions

20. test_swipe_to_delete_public_chat
Device sessions

21. test_send_emoji
Device sessions

22. test_logcat_recovering_account
Device sessions

23. test_messaging_in_different_networks
Device sessions

24. test_send_tokens_in_1_1_chat
Device sessions

25. test_network_mismatch_for_send_request_commands
Device sessions

26. test_logcat_sign_message_from_daap
Device sessions

27. test_swipe_to_delete_1_1_chat
Device sessions

28. test_switch_users_and_add_new_account
Device sessions

29. test_send_stt_from_wallet
Device sessions

30. test_send_eth_in_1_1_chat
Device sessions

31. test_login_with_new_account
Device sessions

32. test_send_eth_from_wallet_to_contact
Device sessions

33. test_add_contact_from_public_chat
Device sessions

34. test_send_two_transactions_one_after_another_in_dapp
Device sessions

35. test_password_in_logcat_creating_account
Device sessions

36. test_backup_recovery_phrase
Device sessions

37. test_offline_status
Device sessions

38. test_open_google_com_via_open_dapp
Device sessions

39. test_unread_messages_counter_public_chat
Device sessions

40. test_sign_message_from_daap
Device sessions

41. test_user_can_remove_profile_picture
Device sessions

42. test_share_contact_code_and_wallet_address
Device sessions

43. test_request_eth_in_wallet
Device sessions

44. test_refresh_button_browsing_app_webview
Device sessions

45. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@churik
Copy link
Member

churik commented Mar 6, 2019 •
edited
Loading

Thanks @cammellos!
Works perfectly on IOS , Android and Mac OS.
Also checked case when manually select timezone.

@cammellos cammellos force-pushed the bug/wrong-datemark branch from 221f4a8 to 382eeaa Compare March 6, 2019 18:38
@cammellos cammellos merged commit 382eeaa into develop Mar 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/wrong-datemark branch March 6, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@yenda yenda yenda approved these changes

Assignees

@cammellos cammellos

@churik churik

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cammellos @status-im-auto @statustestbot @churik @yenda @rasom