-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21135] handle unsupported wallet address #21820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen-ghafouri
commented
Dec 13, 2024
@@ -18,6 +18,10 @@ | |||
(def parameter-separator "&") | |||
(def key-value-separator "=") | |||
|
|||
(defn- address? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to remove circle dependency, have to define it here
Jenkins BuildsClick to see older builds (8)
|
shivekkhurana
approved these changes
Dec 13, 2024
vkjr
approved these changes
Dec 15, 2024
mohsen-ghafouri
force-pushed
the
fix/scanner-unsupported
branch
2 times, most recently
from
December 16, 2024 06:09
db76a62
to
d585db3
Compare
100% of end-end tests have passed
Passed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
|
smohamedjavid
approved these changes
Dec 16, 2024
@mohsen-ghafouri Hi! |
mohsen-ghafouri
force-pushed
the
fix/scanner-unsupported
branch
from
December 16, 2024 14:43
d585db3
to
becd688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21135
Summary
Convert all addresses down to plain eth address
The addresses should be fetched without prefixes and chain ids .
discussed with design team
Areas that maybe impacted
Steps to test
Result
IMG_2367.MP4
status: ready