Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21135] handle unsupported wallet address #21820

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Dec 13, 2024

fixes #21135

Summary

Convert all addresses down to plain eth address
The addresses should be fetched without prefixes and chain ids .

discussed with design team

Areas that maybe impacted

  • Universal scan wallet QR
  • Scanner in 'Send to' page

Steps to test

Result

IMG_2367.MP4

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Dec 13, 2024
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review December 13, 2024 17:55
@@ -18,6 +18,10 @@
(def parameter-separator "&")
(def key-value-separator "=")

(defn- address?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to remove circle dependency, have to define it here

@status-im-auto
Copy link
Member

status-im-auto commented Dec 13, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
6334c05 #1 2024-12-13 17:56:16 ~3 min tests 📄log
✔️ 6334c05 #1 2024-12-13 17:59:24 ~6 min ios 📱ipa 📲
✔️ 6334c05 #1 2024-12-13 18:02:03 ~9 min android-e2e 🤖apk 📲
✔️ 6334c05 #1 2024-12-13 18:02:32 ~10 min android 🤖apk 📲
db76a62 #2 2024-12-16 06:01:08 ~3 min tests 📄log
✔️ db76a62 #2 2024-12-16 06:04:40 ~6 min ios 📱ipa 📲
✔️ db76a62 #2 2024-12-16 06:06:52 ~9 min android-e2e 🤖apk 📲
✔️ db76a62 #2 2024-12-16 06:07:18 ~9 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d585db3 #3 2024-12-16 06:14:45 ~4 min tests 📄log
✔️ d585db3 #3 2024-12-16 06:16:36 ~6 min ios 📱ipa 📲
✔️ d585db3 #3 2024-12-16 06:17:39 ~7 min android-e2e 🤖apk 📲
✔️ d585db3 #3 2024-12-16 06:17:53 ~8 min android 🤖apk 📲
✔️ becd688 #4 2024-12-16 14:48:33 ~5 min tests 📄log
✔️ becd688 #4 2024-12-16 14:50:24 ~6 min ios 📱ipa 📲
✔️ becd688 #4 2024-12-16 14:52:41 ~9 min android-e2e 🤖apk 📲
✔️ becd688 #4 2024-12-16 14:53:13 ~9 min android 🤖apk 📲

@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/scanner-unsupported branch 2 times, most recently from db76a62 to d585db3 Compare December 16, 2024 06:09
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 0
Passed tests: 8

Passed tests (8)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

@Horupa-Olena Horupa-Olena self-assigned this Dec 16, 2024
@Horupa-Olena
Copy link

@mohsen-ghafouri Hi!
Thank you for your PR! Everything work is good and the PR can be merged.

@mohsen-ghafouri mohsen-ghafouri merged commit 4f6e189 into develop Dec 16, 2024
5 checks passed
@mohsen-ghafouri mohsen-ghafouri deleted the fix/scanner-unsupported branch December 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

Universal QR scanner navigates to wallet when scanning unsupported addresses
6 participants