Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix No tabs are available in the app on Graphene OS #21520

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Oct 29, 2024

fixes #21509

status: WIP

@Parveshdhull Parveshdhull self-assigned this Oct 29, 2024
@Parveshdhull
Copy link
Member Author

Thank you, @churik, for helping me resolve this issue. Could you please attach a screenshot of the home screen and the status.log file for the build?

@status-im-auto
Copy link
Member

status-im-auto commented Oct 29, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
013e03b #1 2024-10-29 06:51:58 ~3 min tests 📄log
✔️ 013e03b #1 2024-10-29 06:55:20 ~6 min android-e2e 🤖apk 📲
✔️ 013e03b #1 2024-10-29 06:55:54 ~7 min android 🤖apk 📲
✔️ 013e03b #1 2024-10-29 06:58:53 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
c76d93c #2 2024-10-29 09:55:14 ~3 min tests 📄log
✔️ c76d93c #2 2024-10-29 10:01:13 ~9 min android-e2e 🤖apk 📲
✔️ c76d93c #2 2024-10-29 10:01:48 ~10 min android 🤖apk 📲
✔️ c76d93c #2 2024-10-29 10:01:53 ~10 min ios 📱ipa 📲
✔️ d768cda #5 2024-10-29 11:01:20 ~9 min tests 📄log
✔️ d768cda #5 2024-10-29 11:02:37 ~10 min android-e2e 🤖apk 📲
✔️ d768cda #5 2024-10-29 11:04:10 ~11 min ios 📱ipa 📲
✔️ d768cda #5 2024-10-29 11:05:50 ~13 min android 🤖apk 📲

@churik
Copy link
Member

churik commented Oct 29, 2024

image

Full logcat: status_no_tabs.log

Full logs: Status-debug-logs.zip

@Parveshdhull Parveshdhull force-pushed the fix/bottom-tabs-issue branch 3 times, most recently from cd7d0da to 617d957 Compare October 29, 2024 10:50
@Parveshdhull Parveshdhull force-pushed the fix/bottom-tabs-issue branch from 617d957 to d768cda Compare October 29, 2024 10:52
@Parveshdhull
Copy link
Member Author

Thank you very much @churik for providing logs. Please can you check if issue is fixed now?

Also most probably it will not create any regressions, but please also test #15164 #14894

@Parveshdhull Parveshdhull changed the title [WIP]: fix No tabs are available in the app on Graphene OS fix No tabs are available in the app on Graphene OS Oct 29, 2024
@Parveshdhull Parveshdhull marked this pull request as ready for review October 29, 2024 11:11
@churik
Copy link
Member

churik commented Oct 29, 2024

Now it is good on both devices when Testmode is off. I believe this is acceptable, we can fix Testmode banner issues separately

Xiaomi:
IMAGE 2024-10-29 15:06:07

Graphene OS:
IMAGE 2024-10-29 15:06:10

@Parveshdhull 🥇

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 703133,702843 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:420: in join_community
        self.join_button.wait_and_click(120)
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that removed user is not shown in the list anymore
    Device 1: Wait for element Button for max 30s and click when it is available

    critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_switch
        self.sign_in.show_profiles_button.wait_and_click()
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: Button by accessibility id:`show-profiles` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @Parveshdhull Parveshdhull merged commit 4f53a2b into develop Oct 29, 2024
    5 of 6 checks passed
    @Parveshdhull Parveshdhull deleted the fix/bottom-tabs-issue branch October 29, 2024 14:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: DONE
    Development

    Successfully merging this pull request may close these issues.

    No tabs are available in the app on Graphene OS
    4 participants