Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Group Admin has no option to Edit a Group Chat #21457

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Oct 18, 2024

fixes #21432
fixes #20956

Summary

Implemented functionality that allows group admins to update group chat details.

Minor Improvements:

  • Moved all group-related files into a single group directory, keeping create and details organized in one place.
  • Made a single group-edit file so we can use the same code for creating and editing groups.
  • Updated group screen names to follow a consistent naming style (like screen/group-details).

Video

output-2024-10-18_15.25.53.mp4

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 18, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 46ceb32 #1 2024-10-18 10:03:19 ~4 min tests 📄log
✔️ 46ceb32 #1 2024-10-18 10:06:03 ~7 min android-e2e 🤖apk 📲
✔️ 46ceb32 #1 2024-10-18 10:06:07 ~7 min android 🤖apk 📲
✔️ 46ceb32 #1 2024-10-18 10:08:38 ~10 min ios 📱ipa 📲
✔️ f0335eb #2 2024-10-21 09:51:45 ~4 min tests 📄log
✔️ f0335eb #2 2024-10-21 09:54:00 ~6 min android 🤖apk 📲
✔️ f0335eb #2 2024-10-21 09:54:36 ~7 min android-e2e 🤖apk 📲
✔️ f0335eb #2 2024-10-21 09:57:35 ~10 min ios 📱ipa 📲
✔️ 6025e4e #3 2024-10-21 10:06:09 ~4 min tests 📄log
✔️ 6025e4e #3 2024-10-21 10:08:40 ~7 min android 🤖apk 📲
✔️ 6025e4e #3 2024-10-21 10:09:16 ~8 min android-e2e 🤖apk 📲
✔️ 6025e4e #3 2024-10-21 10:11:18 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f5de856 #4 2024-10-21 15:13:51 ~4 min tests 📄log
✔️ f5de856 #4 2024-10-21 15:16:17 ~6 min android 🤖apk 📲
✔️ f5de856 #4 2024-10-21 15:19:03 ~9 min ios 📱ipa 📲
✔️ 5c3f73e #5 2024-10-21 16:20:54 ~5 min tests 📄log
✔️ 5c3f73e #5 2024-10-21 16:24:47 ~9 min android 🤖apk 📲
✔️ 5c3f73e #5 2024-10-21 16:24:48 ~9 min android-e2e 🤖apk 📲
✔️ 5c3f73e #5 2024-10-21 16:26:02 ~10 min ios 📱ipa 📲

src/status_im/navigation/screens.cljs Outdated Show resolved Hide resolved
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
    Device 2: Wait for element `Button` for max 120s and click when it is available

    Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:420: in join_community
        self.join_button.wait_and_click(120)
    ../views/base_element.py:100: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (7)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @Horupa-Olena Horupa-Olena self-assigned this Oct 21, 2024
    @Horupa-Olena
    Copy link

    @Parveshdhull Thanks for you PR. All looks good.

    I have only one question - If the admin of a group chat leaves the chat and is later added back, do their admin rights return? Or does the chat continue without an admin?

    @Horupa-Olena
    Copy link

    Also need close feature request after merge #20956

    cc @Parveshdhull

    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented Oct 21, 2024

    Thank you @Horupa-Olena for testing the PR.

    I have only one question - If the admin of a group chat leaves the chat and is later added back, do their admin rights return? Or does the chat continue without an admin?

    I don't know about this. The simplest solution would be to return user admin rights. Or there should be a way to transfer admin rights to another user(will require designs). I am not sure, probably better to discuss this with the team.

    @Parveshdhull
    Copy link
    Member Author

    @Parveshdhull Thanks for you PR. All looks good.

    Thank you, rebased the PR for merging.

    @Parveshdhull Parveshdhull merged commit fae4b34 into develop Oct 21, 2024
    5 checks passed
    @Parveshdhull Parveshdhull deleted the feat/group-details branch October 21, 2024 16:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Group Admin has no option to Edit a Group Chat Add "Edit name & image" for group chat in mobile app
    4 participants