Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swap): remove feature flag #21363

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat(swap): remove feature flag #21363

merged 1 commit into from
Oct 2, 2024

Conversation

briansztamfater
Copy link
Member

fixes #21362

Summary

This PR removes the swap feature flag and makes the feature always available

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Login
  • Verify Swap feature is always available without the need of enabling a feature flag

status: ready

@briansztamfater briansztamfater self-assigned this Oct 1, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Oct 1, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 7e2ff16 #1 2024-10-01 18:27:47 ~2 min tests 📄log
✔️ 7e2ff16 #1 2024-10-01 18:32:03 ~6 min android 🤖apk 📲
✔️ 7e2ff16 #1 2024-10-01 18:32:25 ~7 min android-e2e 🤖apk 📲
✔️ 7e2ff16 #1 2024-10-01 18:33:52 ~8 min ios 📱ipa 📲
✔️ 35e6e10 #2 2024-10-01 23:06:55 ~4 min tests 📄log
✔️ 35e6e10 #2 2024-10-01 23:09:18 ~7 min android-e2e 🤖apk 📲
✔️ 35e6e10 #2 2024-10-01 23:10:13 ~7 min android 🤖apk 📲
✔️ 35e6e10 #2 2024-10-01 23:10:58 ~8 min ios 📱ipa 📲
✔️ 4d47fc6 #3 2024-10-02 15:09:03 ~4 min tests 📄log
✔️ 4d47fc6 #3 2024-10-02 15:10:48 ~6 min android-e2e 🤖apk 📲
✔️ 4d47fc6 #3 2024-10-02 15:11:26 ~6 min android 🤖apk 📲
✔️ 4d47fc6 #3 2024-10-02 15:13:39 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 679c187 #4 2024-10-02 15:22:35 ~50 sec android 📄log
❌ 679c187 #4 2024-10-02 15:22:50 ~59 sec ios 📄log
❌ 679c187 #4 2024-10-02 15:22:52 ~1 min tests 📄log
❌ 679c187 #4 2024-10-02 15:22:52 ~1 min android-e2e 📄log
✔️ 738edf7 #5 2024-10-02 15:32:24 ~4 min tests 📄log
✔️ 738edf7 #5 2024-10-02 15:35:34 ~7 min android-e2e 🤖apk 📲
✔️ 738edf7 #5 2024-10-02 15:36:01 ~7 min android 🤖apk 📲
✔️ 738edf7 #5 2024-10-02 15:37:08 ~8 min ios 📱ipa 📲

@briansztamfater briansztamfater force-pushed the feat/remove-swap-feature-flag branch from 7e2ff16 to 35e6e10 Compare October 1, 2024 23:02
@status-im-auto
Copy link
Member

✔️ status-mobile/prs/android/PR-21363#2 🔹 ~8 min 6 sec 🔹 35e6e10 🔹 📦 android package

mohsen-ghafouri
mohsen-ghafouri approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@mariia-skrypnyk mariia-skrypnyk self-assigned this Oct 2, 2024
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 0
Passed tests: 7

Passed tests (7)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 51
Failed tests: 2
Expected to fail tests: 0
Passed tests: 49

IDs of failed tests: 703133,702782

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:244: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Tap on found: SendMessageButton
    Device 2: Looking for a message by text: Test with link: https://status.im/ here should be nothing unusual. 

    critical/chats/test_1_1_public_chats.py:149: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.chat_element_by_text(url_message).wait_for_element(20)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Passed tests (49)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    5. test_community_discovery, id: 703503
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links_profile, id: 702775
    Device sessions

    3. test_deep_links_communities, id: 739307
    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @briansztamfater.

    Thanks for your PR.
    Looks good on both platforms.
    Failed e2e are not related.
    PR can be merged.

    @briansztamfater briansztamfater force-pushed the feat/remove-swap-feature-flag branch from 35e6e10 to 4d47fc6 Compare October 2, 2024 15:04
    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/tests/PR-21363#3 🔹 ~4 min 43 sec 🔹 4d47fc6 🔹 📦 tests package

    @briansztamfater briansztamfater force-pushed the feat/remove-swap-feature-flag branch from 4d47fc6 to 679c187 Compare October 2, 2024 15:21
    @briansztamfater
    feat(swap): remove feature flag
    738edf7 
    Signed-off-by: Brian Sztamfater <[email protected]>
    @briansztamfater briansztamfater force-pushed the feat/remove-swap-feature-flag branch from 679c187 to 738edf7 Compare October 2, 2024 15:28
    @briansztamfater briansztamfater merged commit 3a4b58f into develop Oct 2, 2024
    6 checks passed
    @briansztamfater briansztamfater deleted the feat/remove-swap-feature-flag branch October 2, 2024 15:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @alwx alwx Awaiting requested review from alwx

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @vkjr vkjr Awaiting requested review from vkjr

    @smohamedjavid smohamedjavid Awaiting requested review from smohamedjavid

    Assignees

    @briansztamfater briansztamfater

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Remove swap feature flag
    4 participants
    @briansztamfater @status-im-auto @mariia-skrypnyk @mohsen-ghafouri