Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account selection drawer with balance tag (#20334) #21356

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Oct 1, 2024

Fixes #20334

Summary

Updates account selection drawer to optinally include a balance tag

Platforms

  • Android
  • iOS

status: ready

@alwx alwx self-assigned this Oct 1, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Oct 1, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b0daee8 #1 2024-10-01 11:15:16 ~4 min tests 📄log
✔️ b0daee8 #1 2024-10-01 11:18:42 ~7 min android-e2e 🤖apk 📲
✔️ b0daee8 #1 2024-10-01 11:19:14 ~8 min android 🤖apk 📲
✔️ b0daee8 #1 2024-10-01 11:22:17 ~11 min ios 📱ipa 📲
✔️ c6bdd1a #2 2024-10-03 06:29:26 ~4 min tests 📄log
✔️ c6bdd1a #2 2024-10-03 06:32:49 ~7 min android-e2e 🤖apk 📲
✔️ c6bdd1a #2 2024-10-03 06:33:16 ~8 min android 🤖apk 📲
✔️ c6bdd1a #2 2024-10-03 06:35:23 ~10 min ios 📱ipa 📲
✔️ 7459a76 #4 2024-10-04 08:35:14 ~4 min tests 📄log
✔️ 7459a76 #4 2024-10-04 08:37:17 ~6 min android 🤖apk 📲
✔️ 7459a76 #4 2024-10-04 08:38:30 ~7 min android-e2e 🤖apk 📲
✔️ 7459a76 #4 2024-10-04 08:41:05 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ae83bf7 #6 2024-10-04 14:57:49 ~4 min tests 📄log
✔️ ae83bf7 #6 2024-10-04 14:59:18 ~6 min android-e2e 🤖apk 📲
✔️ ae83bf7 #6 2024-10-04 15:00:01 ~7 min android 🤖apk 📲
✔️ ae83bf7 #6 2024-10-04 15:02:45 ~9 min ios 📱ipa 📲
✔️ 9031a95 #7 2024-10-07 17:51:53 ~4 min tests 📄log
✔️ 9031a95 #7 2024-10-07 17:54:10 ~7 min android 🤖apk 📲
✔️ 9031a95 #7 2024-10-07 17:55:07 ~8 min android-e2e 🤖apk 📲
✔️ 9031a95 #7 2024-10-07 17:57:07 ~10 min ios 📱ipa 📲

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Oct 3, 2024

Hey @alwx @briansztamfater !

Thanks for PR.
Have one question, will address it to both you guys:

Do we need some king of number reduction rule?
Here is an example of token amount on account and in drawer:

Screenshot 2024-10-03 at 11 09 53

On our design we have DAI example which doesn't help us when we have such tokens as the ETH one.

Screenshot 2024-10-03 at 11 14 56

@alwx
Copy link
Contributor Author

alwx commented Oct 3, 2024

@mariia-skrypnyk I don't know if it's needed but it can be done, of course. We don't have any general rule for that yet (as far as I know).

@mariia-skrypnyk
Copy link

@briansztamfater let us know what do you think 👇

Hey @alwx @briansztamfater !

Thanks for PR.
Have one question, will address it to both you guys:

Do we need some king of number reduction rule?
Here is an example of token amount on account and in drawer:

Screenshot 2024-10-03 at 11 09 53

@alwx
Copy link
Contributor Author

alwx commented Oct 4, 2024

@mariia-skrypnyk just did the number rounding. As agreed in Discord, it's 4 decimals (00.0000)

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Oct 4, 2024

@alwx

ISSUE 1: app crashes when user tries to switch account on Swap screen

Steps:

  1. Login to app
  2. Go to Wallet
  3. Choose Account
  4. Long tap on token -> Swap
  5. Tap on Account icon on the right top of the screen

Actual result:

Screenshot 2024-10-04 at 11 09 40

Crash exist on both platforms

Expected result:

Bottom sheet with list of existing accounts should open

@alwx
Copy link
Contributor Author

alwx commented Oct 4, 2024

@mariia-skrypnyk could you check again? Replaced it with another method, should be safe now (but I cannot reproduce the previous issue either :( )

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 0
Passed tests: 7

Passed tests (7)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

@mariia-skrypnyk
Copy link

Hey @alwx .

See no crash anymore. Thanks!
PR can be merged!

@briansztamfater briansztamfater merged commit a8bc93e into develop Oct 7, 2024
6 checks passed
@briansztamfater briansztamfater deleted the feature/20334 branch October 7, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Account Selection Drawer (From Setup Swap screen)
5 participants