Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet)_: Error on sending ERC1155 collectible #21209

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

smohamedjavid
Copy link
Member

fixes #21183

Summary

This PR:

  • fixes crash while sending an ERC115 collectible
  • fixes routes are fetched if we enter 0 in the input

Platforms

  • Android
  • iOS

Steps to test

Prerequisites: A profile with tokens and ERC1155 collectibles

  • Open Status
  • Navigate to the wallet tab
  • Try sending an ERC1155 collectible
  • Verify no error is encountered
  • Navigate to send token (ETH/ERC20) by picking any
  • Enter 0 in the input field
  • Verify the routes are not fetched

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Sep 6, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f16a47b #1 2024-09-06 19:12:30 ~4 min tests 📄log
✔️ f16a47b #1 2024-09-06 19:14:25 ~6 min android 🤖apk 📲
✔️ f16a47b #1 2024-09-06 19:15:24 ~7 min android-e2e 🤖apk 📲
✔️ f16a47b #1 2024-09-06 19:19:57 ~12 min ios 📱ipa 📲
✔️ e535411 #2 2024-09-10 19:32:36 ~4 min tests 📄log
✔️ e535411 #2 2024-09-10 19:34:40 ~6 min android 🤖apk 📲
✔️ e535411 #2 2024-09-10 19:35:27 ~7 min android-e2e 🤖apk 📲
✔️ e535411 #2 2024-09-10 19:37:25 ~9 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b085754 #3 2024-09-13 10:32:37 ~4 min tests 📄log
✔️ b085754 #3 2024-09-13 10:34:36 ~6 min android-e2e 🤖apk 📲
✔️ b085754 #3 2024-09-13 10:36:03 ~7 min android 🤖apk 📲
✔️ b085754 #3 2024-09-13 10:37:10 ~8 min ios 📱ipa 📲
✔️ 1dcae6f #4 2024-09-13 12:21:35 ~4 min tests 📄log
✔️ 1dcae6f #4 2024-09-13 12:24:05 ~7 min android-e2e 🤖apk 📲
✔️ 1dcae6f #4 2024-09-13 12:25:00 ~8 min android 🤖apk 📲
✔️ 1dcae6f #4 2024-09-13 12:25:47 ~9 min ios 📱ipa 📲

Copy link
Contributor

@ulisesmac ulisesmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @smohamedjavid !

@smohamedjavid smohamedjavid force-pushed the fix/crash-on-sending-erc1155 branch from f16a47b to e535411 Compare September 10, 2024 19:27
@smohamedjavid smohamedjavid mentioned this pull request Sep 10, 2024
@VolodLytvynenko VolodLytvynenko force-pushed the fix/crash-on-sending-erc1155 branch from e535411 to b085754 Compare September 13, 2024 10:28
@VolodLytvynenko VolodLytvynenko self-assigned this Sep 13, 2024
@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 0
Passed tests: 6
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Looking for a message by text: Message AFTER edit 2 (Edited)
    Device 2: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    critical/chats/test_public_chat_browsing.py:378: in test_community_message_edit
        self.channel_2.set_reaction(message_text_after_edit)
    ../views/chat_view.py:1053: in set_reaction
        self.chat_element_by_text(message).long_press_until_element_is_shown(element)
    ../views/base_element.py:327: in long_press_until_element_is_shown
        element = self.find_element()
    ../views/chat_view.py:116: in find_element
        self.wait_for_visibility_of_element(20)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @smohamedjavid thank you for PR. No issues from my side. PR is ready to be merged

    @smohamedjavid smohamedjavid force-pushed the fix/crash-on-sending-erc1155 branch from b085754 to 1dcae6f Compare September 13, 2024 12:16
    @smohamedjavid smohamedjavid merged commit 5d6b46a into develop Sep 13, 2024
    6 checks passed
    @smohamedjavid smohamedjavid deleted the fix/crash-on-sending-erc1155 branch September 13, 2024 12:26
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    "Objects are not valid as a React child" Error Displayed When Attempting to Send Multi-Collectible
    5 participants