-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong composer opacity with minimised keyboard when editing message #20348
Conversation
Jenkins BuildsClick to see older builds (16)
|
92e2022
to
c7437a6
Compare
53% of end-end tests have passed
Not executed tests (1)Failed tests (21)Click to expandClass TestWalletMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (3)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (27)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
[text images link-previews? reply? audio?] | ||
(and (empty? text) | ||
(empty? images) | ||
(not link-previews?) | ||
(not reply?) | ||
(not audio?))) | ||
[{:keys [input-text images link-previews? reply audio edit]}] | ||
(not (or (not-empty input-text) images link-previews? reply audio edit))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check if images
is not-empty
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is being checked for as images link-previews? reply audio edit
is wrapped in a not
c7437a6
to
918d3c0
Compare
LGTM, thanks for the fix @Parveshdhull ! |
918d3c0
to
e1acf01
Compare
fixes #20305
Testing
Please test opacity with all (text, images, reply, edit)
status: ready