move blur lib fork to a patch #19681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
5ad0538
to
851dbcb
Compare
Jenkins BuildsClick to see older builds (25)
|
Parveshdhull
approved these changes
Apr 16, 2024
siddarthkay
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
0bb2fa9
to
95b531e
Compare
83% of end-end tests have passedFailed tests (7)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
|
siddarthkay
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
95b531e
to
1363be2
Compare
ajayesivan
approved these changes
Apr 17, 2024
|
@status-im/mobile-qa : just a smoke test will do for this PR, Ideally I think we could even get a design review since blur related library is upgraded. |
|
@siddarthkay I'll check the tests and then ask Francesca to review it 👌 |
qoqobolo
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
1363be2
to
3eae59b
Compare
96% of end-end tests have passedExpected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (50)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
siddarthkay
force-pushed
the
fork-to-patch-for-blur-lib
branch
2 times, most recently
from
aa2973c
to
68caca0
Compare
|
Hey @siddarthkay, the tests look good. |
siddarthkay
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
68caca0
to
db06d64
Compare
mariia-skrypnyk
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
db06d64
to
c4ad9e8
Compare
Francesca-G
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Blur issue on iOS - Dark theme as commented here
Also (not strictly related to this PR, feel free to address It in a follow up issue if you think that's the best approach)
I've noticed a shadow / line that shouldn't be there, between the channel actions and the date divider, on empty channel screens:
As you can see here it moves when scrolling:
RPReplay_Final1713439050.mp4
Expected behavior:
|
@yqrashawn @Parveshdhull : Do any of you know if this is a new Issue or does this exist already? |
|
hi @siddarthkay,
|
|
@Francesca-G : I'll go ahead and merge this one and we can take this issue as a follow up. Thank you! |
## Summary This commit swaps the fork of @react-native-community/blur with a patch and upgrades the library to latest version of 4.4.0 needed for : #18138 ## Review & Test notes Verify if blur stuff still works. ## Platforms - iOS - Android status: ready
siddarthkay
force-pushed
the
fork-to-patch-for-blur-lib
branch
from
c4ad9e8
to
b6cae3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR swaps the fork of
@react-native-community/blurwith a patch and upgrades the library to latest version of4.4.0needed for : #18138
Review & Test notes
Verify if blur stuff still works.
Platforms
status: ready