Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase numbered keyboard touchable area #18330

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: increase numbered keyboard touchable area #18330

merged 1 commit into from
Jan 5, 2024

Conversation

briansztamfater
Copy link
Member

fixes #18205

Summary

This PR increases touchable area of keys in numebered keyboard to improve responsiveness of touches

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Log in
  • Open wallet, go to send tokens
  • Select a token, reach to input amount screen
  • Verify responsiveness of touches in numbered keyboard

status: ready

@briansztamfater briansztamfater self-assigned this Dec 30, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Dec 30, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 66e3b1f #1 2023-12-30 20:15:13 ~4 min tests 📄log
✔️ 66e3b1f #1 2023-12-30 20:16:08 ~5 min ios 📱ipa 📲
✔️ 66e3b1f #1 2023-12-30 20:17:26 ~6 min android-e2e 🤖apk 📲
✔️ 66e3b1f #1 2023-12-30 20:18:21 ~7 min android 🤖apk 📲
✔️ 3eeaba3 #2 2024-01-03 10:47:50 ~4 min tests 📄log
✔️ 3eeaba3 #2 2024-01-03 10:49:53 ~6 min ios 📱ipa 📲
✔️ 3eeaba3 #2 2024-01-03 10:49:56 ~6 min android-e2e 🤖apk 📲
✔️ 3eeaba3 #2 2024-01-03 10:51:07 ~7 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f99a4af #3 2024-01-04 15:04:10 ~4 min tests 📄log
✔️ f99a4af #3 2024-01-04 15:06:26 ~6 min ios 📱ipa 📲
✔️ f99a4af #3 2024-01-04 15:06:56 ~7 min android-e2e 🤖apk 📲
✔️ f99a4af #3 2024-01-04 15:09:09 ~9 min android 🤖apk 📲
✔️ 65f0e40 #4 2024-01-05 15:44:19 ~4 min tests 📄log
✔️ 65f0e40 #4 2024-01-05 15:46:29 ~6 min ios 📱ipa 📲
✔️ 65f0e40 #4 2024-01-05 15:48:00 ~7 min android 🤖apk 📲
✔️ 65f0e40 #4 2024-01-05 15:48:06 ~7 min android-e2e 🤖apk 📲

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 48
Failed tests: 8
Expected to fail tests: 4
Passed tests: 36

IDs of failed tests: 702809,702733,703133,702948,702745,702786,702845,703629 

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:427: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:427: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    3. test_community_mentions_push_notification, id: 702786

    Device 2: Joining community
    Device 2: Looking for a message by text: https://status.app/c/ 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:427: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:427: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:427: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:469: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:243: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Tap on found: Button
    Device 1: Find ProfilePictureElement by accessibility id: chat-icon 

    critical/chats/test_1_1_public_chats.py:272: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.profile_1.edit_profile_picture(image_index=2)
../views/profile_view.py:443: in edit_profile_picture
    self.profile_picture.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ProfilePictureElement by accessibility id: `chat-icon` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (36)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_edit_message, id: 702855
    Device sessions

    4. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    5. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @qoqobolo qoqobolo force-pushed the fix/increase-numbered-keyboard-touch-area branch from 66e3b1f to 3eeaba3 Compare January 3, 2024 10:43
    @mariia-skrypnyk
    Copy link

    mariia-skrypnyk commented Jan 3, 2024 •
    edited
    Loading

    Hi @briansztamfater ! Nice to meet you and thanks for your PR:)

    I am faced with a crush that blocks me in my testing. Please, take a look on it's details here:

    ISSUE 1: [Android/iOS] app crushes when user tries to select any asset

    Steps:

    1. Open wallet
    2. Tap + to create one more account
    3. Tap on your first Eth account
    4. Open send to page (Flow to open 'send to' page: Open eth address -> tap 'send' -> tap 'my accounts tab' -> tap on created at step 2 account -> tap any asset)

    Actual result: app crushed
    photo_2024-01-03_12-41-29
    I've also attached android logs below.
    Status-debug-logs.zip

    @status-im-auto
    Copy link
    Member

    40% of end-end tests have passed

    Total executed tests: 48
Failed tests: 26
Expected to fail tests: 3
Passed tests: 19

    IDs of failed tests: 702845,702840,702894,703086,702786,702844,702851,703202,702841,702807,702839,702808,702809,702838,704615,702948,702859,703629,703133,702869,702843,702850,703297,703495,702777,703194 

    IDs of expected to fail tests: 702731,702732,703503

    Failed tests (26)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840 
    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    2. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    3. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    5. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    6. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    7. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    9. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    10. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    11. test_community_several_images_send_reply, id: 703194 

    Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:434: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    2. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Find Button by xpath: //*[@text="Undo"] 

    critical/chats/test_public_chat_browsing.py:111: in test_community_undo_delete_message
    self.channel.element_by_text("Undo").click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Undo"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    2. test_community_mentions_push_notification, id: 702786

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    4. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Tap on found: Button
    # STEP: Device1 check that contact appeared in contact list mutually

    /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
activity_center/test_activity_center.py:133: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.just_fyi('Device1 check that contact appeared in contact list mutually')
../views/base_view.py:394: in just_fyi
    self.driver.execute_script("sauce:context=STEP: %s" % some_str)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:405: in execute_script
    return self.execute(command, {"script": script, "args": converted_args})["value"]
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))



    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850

    Device 1: Tap on found: Button
    Device 1: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    activity_center/test_activity_center.py:69: in test_activity_center_contact_request_decline
    if self.home_1.pending_contact_request_text.text != '1':
../views/base_element.py:407: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_add_contact_field_validation, id: 702777

    Device 2: Tap on found: LogInButton
    ## Signed in successfully!

    activity_center/test_activity_center.py:168: in test_add_contact_field_validation
    self.loop.run_until_complete(run_in_parallel(((_device_1_creates_user, {}),
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
activity_center/test_activity_center.py:158: in _device_1_creates_user
    self.profile_1.driver.reset()
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/extensions/applications.py:299: in reset
    self.execute(Command.RESET)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 An unknown server-side error occurred while processing the command. Original error: Cannot start the 'im.status.ethereum.pr' application. Consider checking the driver's troubleshooting documentation. Original error: Error executing adbExec. Original error: 'Command '/home/chef/android-sdk-linux/platform-tools/adb -P 5037 -s emulator-5554 shell am start -W -n im.status.ethereum.pr/im.status.ethereum.MainActivity -S' timed out after 20000ms'. Try to increase the 20000ms adb execution timeout represented by 'adbExecTimeout' capability
E   Stacktrace:
E   UnknownError: An unknown server-side error occurred while processing the command. Original error: Cannot start the 'im.status.ethereum.pr' application. Consider checking the driver's troubleshooting documentation. Original error: Error executing adbExec. Original error: 'Command '/home/chef/android-sdk-linux/platform-tools/adb -P 5037 -s emulator-5554 shell am start -W -n im.status.ethereum.pr/im.status.ethereum.MainActivity -S' timed out after 20000ms'. Try to increase the 20000ms adb execution timeout represented by 'adbExecTimeout' capability
E       at getResponseForW3CError (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/protocol/errors.js:1073:9)
E       at asyncHandler (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/protocol/protocol.js:491:57)



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

    [[Data delivery issue]]

    4. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (3)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (19)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    5. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    @briansztamfater
    Copy link
    Member Author

    Hi @mariia-skrypnyk! Thanks for assigning this issue. About the error you mentioned, there is another PR that tries to fix the error: #18326

    So probably we can give that PR priority once approved.

    @mariia-skrypnyk
    Copy link

    Hi @mariia-skrypnyk! Thanks for assigning this issue. About the error you mentioned, there is another PR that tries to fix the error: #18326

    So probably we can give that PR priority once approved.

    Thanks Brian!
    So I'll wait #18326 to be reviewed and merged and then I will retest current PR :)

    @status-im-auto
    Copy link
    Member

    94% of end-end tests have passed

    Total executed tests: 16
Failed tests: 1
Expected to fail tests: 0
Passed tests: 15
Not executed tests: 32

    IDs of not executed tests: 702730,702782,702731,702745,702813,702855,702733,702783,702784,703391,703496,702807,702732,702808,703202,703297,703495,703503,702846,702742,703133,703382,702869,702850,702851,702777,702936,702947,702957,702958,702775,704613 

    IDs of failed tests: 703629

    Not executed tests (32)

    Click to expand
  • Rerun not executed tests

    • Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1136: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Passed tests (15)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    @mariia-skrypnyk mariia-skrypnyk mentioned this pull request Jan 4, 2024
    Merged
    @briansztamfater briansztamfater force-pushed the fix/increase-numbered-keyboard-touch-area branch from 3eeaba3 to f99a4af Compare January 4, 2024 14:59
    @briansztamfater
    Copy link
    Member Author

    Hi @mariia-skrypnyk! Thanks for assigning this issue. About the error you mentioned, there is another PR that tries to fix the error: #18326
    So probably we can give that PR priority once approved.

    Thanks Brian! So I'll wait #18326 to be reviewed and merged and then I will retest current PR :)

    @mariia-skrypnyk The fix was merged and I just rebased this PR so hopefully we can continue testing this one 🙏

    @status-im-auto
    Copy link
    Member

    73% of end-end tests have passed

    Total executed tests: 48
Failed tests: 10
Expected to fail tests: 3
Passed tests: 35

    IDs of failed tests: 702958,702745,703202,702807,702808,702948,702957,702732,703297,703495 

    IDs of expected to fail tests: 703629,702783,703503

    Failed tests (10)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202 
    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_group_chat_join_send_text_messages_push, id: 702807 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Device sessions

    3. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

    [[Data delivery issue]]

    4. test_group_chat_pin_messages, id: 702732 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    6. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 4.896120557598039 percents 

    critical/chats/test_1_1_public_chats.py:311: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with text 'ё, доброго вечерочка' was not received



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1088: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not all channels are shown in community before joining: ['dogs', 'cats']



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    2. test_activity_center_mentions, id: 702957

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:428: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:610: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1175: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 open community is not listed inside Pending communities tab
E    Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"
E    Joined status is not displayed
E    open community is not listed inside Joined communities tab

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (35)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    5. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @mariia-skrypnyk! Thanks for assigning this issue. About the error you mentioned, there is another PR that tries to fix the error: #18326
    So probably we can give that PR priority once approved.

    Thanks Brian! So I'll wait #18326 to be reviewed and merged and then I will retest current PR :)

    @mariia-skrypnyk The fix was merged and I just rebased this PR so hopefully we can continue testing this one 🙏

    Thanks @briansztamfater for merge and rebase!
    I've checked your fix: everything is fine and it can be merged now!

    @briansztamfater briansztamfater force-pushed the fix/increase-numbered-keyboard-touch-area branch from f99a4af to 65f0e40 Compare January 5, 2024 15:39
    @briansztamfater briansztamfater merged commit e7b92dc into develop Jan 5, 2024
    6 checks passed
    @briansztamfater briansztamfater deleted the fix/increase-numbered-keyboard-touch-area branch January 5, 2024 15:55
    yevh-berdnyk pushed a commit that referenced this pull request Jan 5, 2024
    @briansztamfater @yevh-berdnyk
    fix: increase numbered keyboard touchable area (#18330)
    8961d88 
    Signed-off-by: Brian Sztamfater <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ulisesmac ulisesmac ulisesmac approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @OmarBasem OmarBasem OmarBasem approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @rasom rasom Awaiting requested review from rasom

    @vkjr vkjr Awaiting requested review from vkjr

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @briansztamfater briansztamfater

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Buttons lack sensitivity on send page, resulting in difficulty selecting values when tapped on the edge
    8 participants
    @briansztamfater @status-im-auto @mariia-skrypnyk @smohamedjavid @J-Son89 @OmarBasem @ibrkhalil @ulisesmac