Bump go #18327
Closed
Bump go #18327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (7)
|
58% of end-end tests have passedFailed tests (16)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (28)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
|
siddarthkay
approved these changes
Dec 30, 2023
Parveshdhull
approved these changes
Jan 1, 2024
|
Hey @ibrkhalil! Thanks for the PR! According to failed e2e that the issue is still there. So bumping go version did not help unfortunately. |
|
I ran the TestRequestCommunityInfo on status-go which fetches the community info from store nodes 300 times without failure. INFO [12-30|09:14:15.615|github.com/status-im/status-go/protocol/messenger_store_node_request_manager.go:337] request finished requestID="{RequestType:0 DataID:0x02471dd922756a3a50b623e59cf3b99355d6587e43d5c517eb55f9aea9d3fe9fe9}" communityFound=false contactFound=false shardFound=false error="too many failed requests"It's an error indicating that the request from store nodes came back successfully but couldn't find community. Investigating |
54% of end-end tests have passedFailed tests (18)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (26)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
69% of end-end tests have passedFailed tests (5)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Passed tests (11)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
|
Actually not. If it was a successful request, then a
AFAIK I suggest maybe testing this with We could probably make |
|
@igor-sirotin thank you your feedback on this issue.
Regarding this, from my point of view it is not the best option to get back to the deprecated status.prod fleet during testing process. It would be better to focus on finding the solution for shards.test as it is in fact our new version of prod fleet and we should continue further testing using this fleet. |
@pavloburykh Sure, I agree. I propose to test this just to make sure the problem is indeed in |
@igor-sirotin unfortunately I was not able to test the old status.prod fleet on mobile, because data is not delivered at all on this fleet. |
Hey @igor-sirotin! UPDATE: I have managed to check on status prod fleet and confirm that the issue is there as well. So it is not shards.test specific. |
|
Closing this PR as the issue has been fixed on the shards.test fleet side. @igor-sirotin thanks a lot for investigating and fixing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18315
Summary
Bumps status-go to add Igor's fix to fetchCommunity ability to get community from store nodes, I reproduced the #18315 with this PR, But couldn't reproduce it after testing it on latest status-go.
status: ready