fix: route not found when attempting to transfer assets to own accounts #18325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
requested review from
shivekkhurana,
rasom,
vkjr,
smohamedjavid,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
Jenkins BuildsClick to see older builds (8)
|
OmarBasem
approved these changes
Jan 2, 2024
|
Could you describe what changes you made here? I know what's being done but it will be nice to understand how you are doing it 👍 |
@J-Son89 thanks for the suggestion, updated the PR description with a better description of the changes 👍 |
52% of end-end tests have passedFailed tests (19)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (25)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
|
ulisesmac
reviewed
Jan 2, 2024
Comment on lines
+440
to
+306
| (rf/reg-event-fx :wallet/clean-account-selection | ||
| (fn [{:keys [db]}] | ||
| {:db (update-in db [:wallet :ui :send] dissoc :send-account-address)})) |
There was a problem hiding this comment.
Important step!
Recently I noticed when we navigate to a collectible details, for a moment, we show the previous displayed collectible details. that's because we are not cleaning the collectibles db when navigating back, so it's good we are cleaning these keys 👍
ulisesmac
reviewed
Jan 2, 2024
| @@ -54,7 +59,8 @@ | |||
| (fn [{:keys [db now]} [amount]] | |||
| (let [wallet-address (get-in db [:wallet :current-viewing-account-address]) | |||
| token (get-in db [:wallet :ui :send :token]) | |||
| to-address (get-in db [:wallet :ui :send :to-address]) | |||
| account-address (get-in db [:wallet :ui :send :send-account-address]) | |||
| to-address (or account-address (get-in db [:wallet :ui :send :to-address])) | |||
There was a problem hiding this comment.
We can use the not-found in get-in
(get-in db [:a :b :c] :return-if-not-found)
Comment on lines
+35
to
55
| (rf/reg-event-fx :wallet/select-send-account-address | ||
| (fn [{:keys [db]} [{:keys [address stack-id]}]] | ||
| {:db (-> db | ||
| (assoc-in [:wallet :ui :send :send-account-address] address) | ||
| (update-in [:wallet :ui :send] dissoc :to-address)) | ||
| :fx [[:navigate-to-within-stack [:wallet-select-asset stack-id]]]})) | ||
|
|
||
| (rf/reg-event-fx :wallet/select-send-address | ||
| (fn [{:keys [db]} [{:keys [address stack-id]}]] | ||
| {:db (assoc-in db [:wallet :ui :send :to-address] address) | ||
| {:db (-> db | ||
| (assoc-in [:wallet :ui :send :to-address] address) | ||
| (update-in [:wallet :ui :send] dissoc :send-account-address)) | ||
| :fx [[:navigate-to-within-stack [:wallet-select-asset stack-id]]]})) |
There was a problem hiding this comment.
I think these events only differ in the key where they store the selected address. But why do we need them? I think we could mark in :ui :send a boolean instead 🤔
about the names of the events :wallet/select-send-address and :wallet/select-send-account-address are very similar, maybe we could set a different name more descriptive to understand them better.
pavloburykh
force-pushed
the
fix/routes-not-loading-to-account
branch
2 times, most recently
from
3fe1f95
to
160b94a
Compare
qoqobolo
force-pushed
the
fix/routes-not-loading-to-account
branch
from
160b94a
to
9a28ae0
Compare
73% of end-end tests have passedFailed tests (11)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (35)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
|
|
Hi @briansztamfater ! |
… eth account Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
fix/routes-not-loading-to-account
branch
from
9a28ae0
to
3ba85d6
Compare
briansztamfater
added a commit
that referenced
this pull request
Jan 11, 2024
… eth account (#18325) Signed-off-by: Brian Sztamfater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18232
Summary
This PR fixes routes not being fetched when attemping to send assets to an account from My Accounts tab.
:wallet/select-send-account-addressevent to dissoc:to-addressfrom db, and assoc:send-account-address, also moved navigation to an effect:wallet/select-send-addressevent to dissoc:send-account-addressfrom db, and assoc:to-address:wallet/get-suggested-routesevent, use:send-account-addressor:to-addressas the sending address parameter (previously:send-account-addresswas being ignored and causedgetSuggestedRoutesendpoint to instantly fail)Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready