-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlinify StatusOkHttpClientFactory.java
#18318
Conversation
Jenkins Builds
|
54% of end-end tests have passed
Failed tests (18)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (26)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
@siddarthkay If this PR doesn't require testing, you can merge it, as the e2e failed due to #18315 |
yes @churik : unless the app is not crashing on install or account creation stage the changes in PR are good, It didn't crash when I tested on emulator, can you pls check once on your end? |
65a1eeb
to
e37e677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Successfully installed and created profiles on Android 13 and Android 10 |
Summary
This PR converts
android/app/src/main/java/im/status/ethereum/StatusOkHttpClientFactory.java
toandroid/app/src/main/java/im/status/ethereum/StatusOkHttpClientFactory.kt
Platforms
status: ready